Require a HTTP Client as Payum/Core requires a http client implementation

[jacquesbh]

This requirement is required to avoid a dependency error when we use
Symfony flex recipes.

See https://travis-ci.org/symfony/recipes-contrib/jobs/655281894.

I prefer to put this new requirement in the bundle since I force the http client to be the symfony one.

Update

I think a require-dev is better than a require since it doesn't force the developer to use the symfony implementation of the http-client.

[Tetragramat]

I don't think that this will ever be accepted. You're forcing everyone to install one specified implementation of php-http/client-implementation.
You should find different solution. For example make payum pack repo which has only composer.json with require of payum/payum-bundle and symfony/http-client. And present it as preffered way to install payum using flex on symfony >=4.4.

[jacquesbh]

I disagree because using the symfony/http-client is common sens in a Symfony Bundle.

Right now the bundle cannot be installed without error.

[jacquesbh]

@Tetragramat I've updated the PR to require the http-client as dev dependency.
This should solve the issue you are pointing out.

What do you think?

[Tetragramat]

That will not even fix your issue. Look at PR with similar issues symfony/recipes-contrib#395 and symfony/recipes-contrib#464 to get idea what to do.

[jacquesbh]

Ok yes. So the recipe was merged even with the CI failing.

So I close this.