Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unary minus operator for SD59x18 #173

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Add unary minus operator for SD59x18 #173

merged 2 commits into from
Mar 18, 2023

Conversation

Lumyo
Copy link
Contributor

@Lumyo Lumyo commented Mar 14, 2023

This adds ability to directly use -x on an SD59x18.

@PaulRBerg PaulRBerg force-pushed the main branch 2 times, most recently from a6d3a9f to 4280425 Compare March 17, 2023 17:58
PaulRBerg
PaulRBerg requested changes Mar 18, 2023
View reviewed changes
Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Feedback below.

test/Base.t.sol Outdated Show resolved Hide resolved
test/sd59x18/helpers/Helpers.t.sol Show resolved Hide resolved
Lumyo
Lumyo commented Mar 18, 2023
View reviewed changes
test/Base.t.sol Show resolved Hide resolved
@PaulRBerg PaulRBerg merged commit cad4d2c into PaulRBerg:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lumyo @PaulRBerg