Hollow Palm Technique proper Dual Wielding #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Oct 20, 2024
LocalIdentity
merged commit fb447c5
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8302.
Properly set hollow palm to dual wield, rather than just setting the condition, that means mods which apply to the main/off hand will give their proper results, rather than potentially being over inflated or not counted at all,
This also fixes
Ice Crash of Cadence, but thats likely not intended based on the skill description.This is a little messy, but its because keystones are not merged until calc perform, and so the best I can do is check for the keystone name, this only runs if the weapon 2 slot is empty, and you are unencumbered (no weapon 1/weapon2/gloves)