Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mana cost raw not being set to 0 when using lifetap #8233

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Mana cost raw not being set to 0 when using lifetap #8233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1608,8 +1608,9 @@ function calcs.offence(env, actor, activeSkill)
val.baseCostNoMult = val.baseCostNoMult + costs[manaType].baseCostNoMult
val.finalBaseCost = val.finalBaseCost + costs[manaType].finalBaseCost
costs[manaType].baseCost = 0
costs[manaType].baseCostNoMult = 0
costs[manaType].baseCostRaw = 0
costs[manaType].finalBaseCost = 0
costs[manaType].baseCostNoMult = 0
elseif additionalLifeCost > 0 or hybridLifeCost > 0 then
val.baseCost = costs[manaType].baseCost
val.finalBaseCost = val.finalBaseCost + round(costs[manaType].finalBaseCost * (hybridLifeCost + additionalLifeCost))
Expand Down
3 changes: 3 additions & 0 deletions src/Modules/CalcTriggers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,9 @@ local function defaultTriggerHandler(env, config)
end
trigRate = trigRate / m_ceil(manaSpentThreshold / sourceManaCost)
else
if breakdown then
t_insert(breakdown.EffectiveSourceRate, s_format("Source skill has no mana cost", output.EffectiveSourceRate))
end
trigRate = 0
end
end
Expand Down
Loading