Scale Warcry buffs by Warcry Power earlier in Calc #8109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warcry Buffs are scaled and floored before warcry power is taken into account, this causes the numbers to be wrong, especially when also scaled by uptime, tested all warcries ingame except rallying cry and all were wrong and are fixed by this change except for infernal cry (will talk later about it)
This change also removed duplicate buff code for minions to check parents warcry power, and makes it easier to implement party tab support for warcries
The downside of this change is the buff notes are less informative, but that can be changed by changing the notes if we want it to show there
Before screenshot:
After screenshot:
All of them tested on multiple builds but here is an example of a minimum test setup: https://pobb.in/2qs_Nsh4BIBy
As for infernal cry, it seems it is not scaled by warcry effect?
The values now line up correctly for 0% increased warcry effect at varying power levels from 0 power to infinite power, but ingame does not seem to scale with warcry effect, it applies the same 7-13 at 0% inc effect as it does at 200% increased effect (tested on 5 different builds and had the same results) (edit already reported here https://www.pathofexile.com/forum/view-thread/3541517)