Fix autoexertion not triggering supported skills #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
added
wip
LocalIdentity
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8017
Description of the problem being solved:
Fixes autoexertion not triggering supported skills.
This does not currently fix the support effect not causing warcries to reserve mana. This issue is caused by missing:SkillType.HasReservationflag causing the reservation calculations to be skipped herePathOfBuilding/src/Modules/CalcPerform.lua
Line 1532 in 0904a87
Problem is there's no good way to add the the flag without also making the skill incompatible with the support effect as it excludes skills with that flag.Requires #8029 to solve mana reservation issue.