Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search to the Calcs tab #7763

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

cooperaustinj
Copy link
Contributor

Description of the problem being solved:

It is sometimes difficult to find what you're looking for in the Calcs tab since there are a lot of sections and calculations.

This PR adds a search input to the Calcs tab. When searching, matching labels on the page are highlighted. Both section titles and individual calculation labels are able to be searched. The search box can be focused with ctrl + f, as you'd expect.

Steps taken to verify a working solution:

No automated testing is added for this feature.

  • ctrl + f focuses the search input and selects any existing text
  • Changing tabs with an active search doesn't cause issues. Returning to the Calcs tab with an active search maintains the search as expected.
  • Custom highlighting color codes work (set in Options -> Hex colour for highlight nodes)
  • Collapsing and expanding sections works while searching and not searching
  • Matches partial searches and is case insensitive
  • The page looks and works correctly when scrolling on skinnier viewports
  • No issues created by entering the max chars in the input (100)

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

search.mp4
search.mp4

@LocalIdentity LocalIdentity added the user-interface Changes that only affect the UI label Jul 21, 2024
@Wires77 Wires77 merged commit 30e07ee into PathOfBuildingCommunity:dev Jul 21, 2024
2 checks passed
@Regisle Regisle mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants