Add support for spark maximum hits mode #7690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
reviewed
Jul 20, 2024
| local skillData = activeSkill.skillData | ||
| if activeSkill.skillPart == 2 then | ||
| skillData.dpsMultiplier = ( skillData.dpsMultiplier or 1 ) * math.floor( output.Duration / 0.66 ) | ||
| output.SkillDPSMultiplier = ( skillData.dpsMultiplier or 1 ) |
There was a problem hiding this comment.
This could never be 1, since we set skillData.dpsMultiplier right above it.
LocalIdentity
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7612 (at least the intention behind it).
Description of the problem being solved:
Adds a new mode for Spark & Spark alt qualities that uses the maximum amount of possible hits with the given spark duration assuming a 100% hitrate after each 0.66s cooldown period.
Didn't add the mode to Vaal Spark, as its mechanics are different to normal Spark & a DPS number is useless for it anyways.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/18bN-kP4WaPe
Before screenshot:
After screenshot: