Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability when dropdown control label has colors #7403

Closed
wants to merge 3 commits into from
Closed

Improve readability when dropdown control label has colors #7403

wants to merge 3 commits into from

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Mar 23, 2024

Fixes # .

Description of the problem being solved:

When drop down label has color, when it's active, it hurts readability by a lot

Most UI libraries don't alter colors at all (ex: https://designsystem.digital.gov/components/combo-box/)

Before screenshot:

image

After screenshot:

image

@ryuukk ryuukk marked this pull request as draft March 23, 2024 17:05
@ryuukk
Copy link
Contributor Author

ryuukk commented Mar 23, 2024

I will try to following too:

  • make 'hover' draw a overlay instead (rectangle)
  • highlight the selected one with a rectangle too

@Paliak Paliak added the user-interface Changes that only affect the UI label Mar 24, 2024
@ryuukk
Copy link
Contributor Author

ryuukk commented Mar 27, 2024

Improvement now lives here: #7492

@ryuukk ryuukk closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
user-interface Changes that only affect the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryuukk @Paliak