Fix tooltip for maximum charges granted from overriding sources #7328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7326 .
Description of the problem being solved:
Currently there is no mod in the modDB to display for overridden maximum charges from Badge of the Brotherhood and the Masterful Form Slayer Ascendancy.
This PR implements a step in
doActorCharges
to add anOVERRIDE
mod to the modDB which gets picked up in the tooltip.I'm not sure this is the best way of doing things as adding to the modDB during the calcs seems like bad practice. Happy to discuss and implement changes as suggested by others.
Also given how many times doActorCharges is called, this implementation uses a
modDB:HasMod()
call to check if the mod already exists. It seems likemodDB:HasModInternal
has a very unique implementation of source matching:As such, I've ensured that the sources in the
modDB:HasMod()
call follow the same treatment but it appears the matches would occur for any source that matchesItem
orTree
for the sources Badge of the Brotherhood and Masterful Form respectively.Steps taken to verify a working solution:
After screenshot: