Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using opening wiki for skills granted by items #7309

Merged

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Jan 25, 2024

Fixes #7307

Description of the problem being solved:

Granted skills do not have gemData which we use to load the wiki, this PR uses the grantedEffect.name if the gemData does not exist in the case for granted skills like Arakaali's Fang and Guardian's Summon Sentinels of Radiance etc.

Steps taken to verify a working solution:

Hit F1 on lots of things

  • Warden's Barkskin
  • Guardian's RF boi
  • Arakaali's Spider boi

One issue that would be a little gross to fix is Necromancer's Bone Armour because it shares the name of the body armour base and for the wiki it wants "Bone Armour (skill)" and it's probably the only special one. For now it loads the body armour but the link to the skill is on the wiki at the top.

edit: here's a working hardcode for Necro in ItemTools
image

Link to a build that showcases this PR:

eNrtHGtz47bx8_lXcDTTTtI5S3yIerh2OrJlnzW17xzJvms_ZWASkhCDhEKC9imd_vcuAFKiHqBIi-mnXGZyErHvXSx2F9Sd_-N7QI1XHMWEhRcNq2k2DBx6zCfh7KLx9Hhz2mv846eT8wfE51-mlwmhYuWnkw_n8rNB8SumgNcwOIpmmH_NKDm_AKUFCvkcs_Ae_cqiT8y_aHxmIW4Yzyj0Cc--eRTF8WcU4IvGIw4WFEUNA8UeDv2r9cqnBEU-QSGAz1GEPI6jO8F7kHB2z3yA4FECxAJEwgnzXjD_FLFkIUV7JfhNwYzuH76MH3OCkTAvGOj14fyBoiWOJhxxI4b_XTQGHievGEBBsTsSEA4UEU2AnG02WhocMCma4dsc8CHYyySK-RAF8PEwzmSBsb8Ga7b7nW7X7Pd6brdtd3VYDxG-nk6x1OcqIvxqjkKvBLeqsPcJ5WRBCY5W8FbT1WHc7hC3TC35R8YRHT5MDguiIFkJB3wjfH5JwaCl6Aro0SwkHJcGf2AkZmElqUsBXyWUwnYsBTvGMY5eESclBbliwTMJS9rkijHqs7dwvTOapuXooO9RiK5YXMIzAvIBR5ALeCWECfYYpI-qPCpi3pEpLg9ZSY8Uoao079PjelIWrjLh9wk0hhxYDnLCEloSkq-Tke3od8lveUDLsnSQQ_x9DdYuoJcHdHs6wFHIy4mXB7T0kEP8ysReL5lxrm8fVpAdswkniWvbVqfb7mklfpgvY-Iheo--kyAJIIs_ohe8Ztix9JE6m_MQEpcO1dEyvSERro51BdnpHVhzxOLqaGIfljACnODemYAdhV65zf0URjKH5w7-IhtP8Ri2nKgtnikuibFmkW7cMkeyYjXDYcpvWU6dO4y9-Sco18aI43Jper2Pis0qYEuZVQDuMaveuZsI20bqtpsubB3T6duW2-kXEdEYrFmIVNFk1yGOZsvJnGDqV4POBLtCi1K1qHeWx86b3i3HrlL05FErmuQbdBHlzp-qMr2iOJ9uLbfYXAq8XJBiqE0Bwcdla_CHiP0qqnxaDW0QBSyJSjpcAecV0J-C2VGhupsx9hOv3Nl0SaGVKys-iEVpJYwB58h7GTJ_hisxqYSx6rgk6iRZLCB9COeXJSDOPKjeSa7KOe2UgP4CkVtqA4vjsTyDNXRpBqsDvzyXLZTyuohDu4Iya_DSLFYOvYfcEED-l834PVsnFu3pdAMNW6mGSgKW7AIf2BtIPhfzl7gaNBQ36zNPK0qEw9-XpelvgJdicB36SSS2Qmke2xil2JQY46jF3dHM1lSmZ7nNTr9rth3L7XddHfLmjMZqmm2rk_3p1oq0MxTptfvNTq_dtvp9t2f2ivH2jEh2IPeOSEpy2T8wKYm8Ozqx21bzEPimv_qdbtMukm6XidVzu00rE886ZMANVNPsNrVBUTCy2YE9MLLZpb1nZFNSkY2mxWl3OkWAxaXRXpTiMm0HpbByLYSuKFv5UvKRBFCHxfEQcWT4aXf9FUUEhdyWY-YYo8ib38FRcoMofYbK4qKRfyq_ydH0DaEcR0N4JpKY4LFN0coOkfOWHLSLT6NgwSJu4O_irwcU8eVFY4pojBWgfAJ0Yk5CGTOQvihtGJM5exv4r4LTI2M0zpAMtFjg0N-g8RhhbKCsWvGEEFJ58cUIUAxSL9XxFwttclP6kS9SrxEyEEB0ma7tfuy3rfZHx-n1ux_bpmmZH9vtfvtjz2478L0vTCNGQihaDjbpiNsEECR3l2A76TWBWHalTB_On8Z38sOHOeeL-KzVent7ay4Qn7Mp_g61b9NjQWsBSKDNafxCKD0VZFsD-HM5e7q9HI0X4TUb_0oGv8OjC0m0lVE9V7cIcUt9E9VBREA5FQ0tYRHpHmEy8eEz4zgWa-Jh9uV8ItjG4PaIf8JBfLmEvXkjgm1rt6Y2F9ATzFU45XGy6w0fT1FCxfOfE0SJCAEz__RO3ceELApWkxkgBSEgCk9F8XG5ED4a3N2plQHlKTHBLosH5fdUIIP4WSykD-VFy2At9RWiXizlJqFHEx-PwrTYWcUbRc9CNqFZEomwH3EcnNnQSaAXBPz_ihYs_nts3KBw9tEAK4W-MUSzmbhFwKGYYviZGWLKROrGgBEaVmNbmJWsH85BpRT5E2XPiNorcWREpAlhU4PcSvpwsgDXR-pRI3fpJSFFTD5GRAiK_UkSBEBQwu_ykEi_5TyXfhYkhsqJjQ1xrUzjLQN4LAlVmIQoSPfqGJEYG4p1vMF7S4E0pFtSpJp9KrbDmdjiOyK_x0eppaFAW5v6EkUv8CX84wy54vCHG0okxFoMpQ_mfSZUQTpG4kKVT6CDgTxE_8_RqmQwMu4GmxpKIA9vxW529bsStKJbQkL3OUY-XrnlkA8EtN4LCiln6hkOhJXuMUc-FAwtkerilsivrXUiVgOARyYLa1FwyKNf4G2spAgb_pNPtvD_KE8pNgZnhmK0Y_70I5wT8kRUZ574KB0gIUbhIuGS5kUjILH3y3MynYo7edCKR_Jlg-ubm-urx9HX67TgyqNIzX8Jk-BZZFX197rNnmA5TjLi5DlWHy8aXwl-k4IMwQWExkI1StEixquKRx5qqeQU8AqoSahbsrqe309rDaCndP0dRxDFs29QFUYEa-VarR8QSjEU1a4oUHXURI-nJ6TGYFdQ3qnKV2Opxcr5e6mIi3-tOmKxABdKW0S1nNPVA5bgoqyBgCVT4okKv9jloghSUAV28bwkQt6ywN_pDE9PI92b-wnk9tNeZNWX6rDT1QKryqZba1W1qkcfYg9pdVeLeuRVM8VC-RLMfiorqAJKn9N-HjbNgFAxb9N69priFYie4Bc-x1Haxego3UOOykAKN05EnhOu38Y5iAJbyeZbYyGxpkdVt2IaHcRaQSba6LE1Bs3D6EmpWxVtIitCVbNXrf3SSW6BC9I7C4351WqBEbJrG43-6XLBJpH5d_DKiK9KF8122QIrShjQdx5PRl5RHE9m-87ieIo30Ma_aP2drurRnzgRhc0eKqqAKUVEbKrjKIi9dRyF8XYhscYdF5cQqzH5XuRstWjjp9Pzd1NQM_53o8sriHdjy_QNRS0GDQrz9wqmILx5Eg7BGLwgtEuSkmLtzwNr7SrRUifZXk0rU1T7M32FpWgLK5ADhOAovi0o9spRWl2j3WJExQye0eMI7ryqc5SejMco9IdinHykomIanSyAWCbZl33V-tql21TPW1kfJeezorNJp8oTDl3QDPYyj43m31R_2DB-Zyz4t3iNq9d0LbdnW47Z6fbU83Q-6KQzQSiAhwT8EMn4yYQQgP-CPtZymnbbtB2367R76l7tXDay6bhSfM6mlUmM1Rt-aignH-cGiQI0P0QcQ6_Ll2fG0-fRz0_XJ_tGgCf5CeBJOqE8M2zzJJ3MnhmXp_DfidRpjH87M1znBHoFSjwiVq2TtvkX0fhHGIGJDdX5GqIVES8jGGA98oINVcKfWCYAe6tWNx3oGZK4YRkbwzUDPPxPsPXJf8D2M3xmNt3__mB1zVPbNH_Ms8xefDCUT_PwA9-PjR96p5bzo-D3g22eOuaPOxgSzBIQbt-Qt9XZiuXm5VXNgBAMokz259BdjwU3Q_IU7xa5jdQFaQevhbAPQjgHIdoHIdyDENktlByfbMaR_Wcc_RlHx8WRuNfQp63NKw_KuAHdcvDw_DS-E_NCNZda30CIxVFeZR3KJabcGDwv41iEjoxAw17jm4fwM5bbNNzqNOwaaFjG5A0ttgl1alCoU4NCVWhcMjjytwk4FQjcYijYdnxrVRFhT2y8ywz7fOLW4BOrBhrtigapKybr2GRVaMgOsJLV90agfWT8OJVFruIgOAtfcXxMmOzfNZ3KFCqraR2tZhXfDoKEYl5DCDo1pEXnaNXblc1dJY7H0GC-Z7-qxFdZuWO3qFvZGMcfK_bRFI6XoX2s4dp15XankiT-0lCD4frzllvXaW3Vo5F9rIsqV1BHp5ZOPZq7RwviVM1Y1rHGtmrI7bXtKbceP3SOrF-Or0aOraBq2opOXamhNkLvaS3eZ4u6YrImV7x7jxwZSbWdDnYNiaIOGlZdCtWWtXYJqamPejlJTNCRjydyev4Ni98YxWrELufa8p0lFk7JLPsJiYfnjPo4SlnjEAfL9Cca2VtI3fwvY_fB5__1jAzJLUbZ_MFcjtdhTtsozgHp0t_kMUrl7CyvlxYxWP37HuLXE_K1V_kGkXh5bILpNPeK1gFFs_SwgreL4Vf39RlCR2-SmMwI_TKVt40gn7wy3Xx17LyVefu8tf0v3PwPxCybog==

@Peechey Peechey added the bug Something isn't working label Jan 25, 2024
@LocalIdentity LocalIdentity added the crash Causes PoB to crash and is High Priority label Jan 25, 2024
@LocalIdentity LocalIdentity changed the title Fix loading wiki for granted skills Fix crash when using opening wiki for skills granted by items Jan 25, 2024
@LocalIdentity LocalIdentity merged commit c4a19f4 into PathOfBuildingCommunity:dev Jan 25, 2024
2 checks passed
@Peechey Peechey deleted the fix/granted_skill_wiki branch January 25, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing F1 on a non-gem skill crashes pob
2 participants