Fix interaction between Chieftain Tasalio node and increased/more fire resistance modifiers #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7191 .
Description of the problem being solved:
Current implementation in
CalcDefence.luaonly converts base fire resistance but based on screenshots from linked issue, increased modifiers also apply. Extrapolating this to apply to more multipliers as well.This PR applies increased and more modifiers to cold and lightning resistances using the conversion rate.
For discussion
What is the appropriate source for the converted increased and more modifiers? Should it still be the same as the original source or the same as the base conversion "Fire to X Resistance Conversion"? I've opted for the former due to potential confusion when there are multiple items.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Refer linked issue
After screenshot: