Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectre Affliction Support Enhance #7135

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

justjuangui
Copy link
Contributor

@justjuangui justjuangui commented Dec 21, 2023

Description of the problem being solved:

We don't currently export mob tags and this is needed for the buff from Hulking Miscreation to work. Tags are in CorpseTypeTags.dat and needs to be cross-referenced with MonsterVarieties.dat

We don't support adding mods to the spectre mob itself, only its skill. We'd need this to more easily apply the bufffs some of the perfect mobs give. I had to give Perfect Dark Marionette another skill with the Scorch stat on it instead of just adding the scorch stat to the mob itself

Solution:

  • create a directibleTable function to build a list of corpsetypedict
  • on emit function call the previous function

image

Improvements:

  • Spectre Hulking Miscreation was added
  • mod minionmodifier was implemented for spectres
  • mod playermodifier was implemented for spectres
  • Spectre mod playermodifier / minion modifier was implemented like buff and minionbuff
  • BreakDown tooltips for Spectre Buff was added
  • Moster Category was added in Spectre Popup, CorpseType was added to Mod validations

image
image
image
image
image
image

@Nightblade
Copy link
Contributor

Hey there, I just wanted to thank you for contributing, and mention that the existing code base uses lowerCamelCase for non-class names, so it would be great if you could adjust your PR accordingly.

For example, buildcorpsetypes should ideally be buildCorpseTypes.

…nted for spectres, mod playermodifier was implemented for spectres, Spectre mod playermodifier / minion modifier was implemented like buff and minionbuff, BreakDown tooltips for Spectre Buff was added, Moster Category was added in Spectre Popup, CorpseType was added to Mod validations
@justjuangui justjuangui changed the title identify the corpsetype base on tags and corpsetypetags.dat Spectre Affliction Support Enhance Dec 22, 2023
@justjuangui
Copy link
Contributor Author

Hey there, I just wanted to thank you for contributing, and mention that the existing code base uses lowerCamelCase for non-class names, so it would be great if you could adjust your PR accordingly.

For example, buildcorpsetypes should ideally be buildCorpseTypes.

Done, thx!

Also I added another improvements

@Paliak Paliak added the enhancement New feature, calculation, or mod label Dec 22, 2023
LocalIdentity added 2 commits January 4, 2024 18:04
Change variable name as Monster Category is more correct
Add parsing for the more attack damage mod on the Hulking Miscreation
Move the export of the monster category to under the monster name
@LocalIdentity LocalIdentity merged commit fc6f954 into PathOfBuildingCommunity:dev Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants