Fix support gem crosslink issues.

[Paliak]

Fixes #6618

Description of the problem being solved:

When a skill is added from some other source than a gem new a group is created for that skill specifically. Currently support gems from the groups socketed in the source slot are copied over (This is quite inefficient as they need to be processed separately). This only happens in the MAIN calc mode as is assumed to have been done in CACHE and CALCS modes. The linked issue is caused by the dps tooltip comparison using the CALCS mode for calculations which causes the support gems that may have changed to not be copied over.

This pr reworks the way support gem cross linking is handled in general to better handle possible cases where doing so may be needed.

I will add some tests after i figure out what is causing ac203b7

Steps taken to verify a working solution:

• Test Empower, Enhance supports
• Test Energy Blade
• Test Various combinations of linked groups
• Test Uul-Netol's Vow and The Squire

TODO:

• Treat each socket group as an in game link group with the exception of groups created by skills coming from items and when an item is crosslinked to another by a mod. In such cases apply all supports from all groups socketed in sourcce item to all groups socketed in target item
• Apply simillar logic to above to the gem dropdown
• Check if more filtering can be applied to the lessen the amount of calcFunc calls when calculating gems for dropdown.

Link to a build that showcases this PR:

https://pobb.in/3o5KNz0wEfyH
https://pobb.in/1ygiNxHUhLno

Before screenshot:

After screenshot:

[gaaasstly]

Is there a bug with alternate quality dps calculation? Why would Anomalous Multistrike be above Superior or Divergent?

From the wiki

Superior
Supported Skills deal 0.5% increased Melee Physical Damage

Anomalous
Supported Skills have 1% reduced Attack Speed
Supported Skills have 1% increased Area of Effect per Repeat

Divergent
Supported Skills have 0.5% increased Attack Speed

Switching from Anomalous to another quality gives a dps increase.

[Regisle]

Sounds like quality isnt taken into account when that is done and those are just sorted by the base gems dps change and then alphabetically

[Paliak]

@gaaasstly Thanks for testing. Latest commit should fix the issue.

[Paliak]

This currently has issues with cases where there are multiple link groups in the same item which causes them all to be linked together and causes the gem dropdown to show supports considering all active gems in the current item.

Need some more time to think how to go about solving this.

[Paliak]

Needs testing again after fixing noSupport flag. Also there's some duplicate code that could be pulled out into a function.

[sida-wang]

This should resolve #647 - don't mind me, just going through old issues sorted by likes

[UchihaWind4U]

I notice the spider's basic damage of Arakaali's Fang is changed into 586 to 879 from 716 to 1074 from 2.38. Is this change a number fix or missing?
2.38 basic damge

2.39 basic damge

Waiting for your reply.

[sida-wang]

Per the v2.39.0 Release notes

Fix longstanding issues with minion stats (more fixes will come in future updates) by (@LocalIdentity, @ifnjeff) in #7253
Some Minion Attacks will reduce by 10-30% DPS

Don't believe the damage change has anything to do with this PR which only affected support gem applications.