fix: vendor older and faster LuaJIT build #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4053210. # Conflicts: # CMakeLists.txt # stb_image_resize.h
There's some regression in LuaJIT performance where the key metric that indicates if a build is slow or fast is file size, where smaller DLLs are faster. Use a specific older commit c7db8255e1eb59f933fac7bc9322f0e4f8ddc6e6 of LuaJIT in a local vcpkg-ports tree to mitigate runtime problems with gem dropdowns for now.
While recovering the vcpkg-ports tree from an earlier commit via revert some unrelated changes slipped through despite auditing the merge and wasn't caught by an incremental rebuild. Re-add the include directory for the vendored stb libraries.
Wires77
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some regression in LuaJIT performance where the key metric that
indicates if a build is slow or fast is file size, where smaller DLLs
are faster.
Use a specific older commit c7db8255e1eb59f933fac7bc9322f0e4f8ddc6e6 of
LuaJIT in a local vcpkg-ports tree to mitigate runtime problems with
gem dropdowns for now.