Update UserDetailsFrom style for escrow verification flow #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinjameson
changed the title
devinjameson
commented
Dec 9, 2020
| _event: Event, | ||
| testDate: Date | undefined, | ||
| ) => { | ||
| setShowDatePickerAndroid(false) |
There was a problem hiding this comment.
This line seems weird, but there's a really UI bug that occurs if it's not included. Found in the issues for the date picker library.
There was a problem hiding this comment.
Could we make sure to mention this in the commit message?
There was a problem hiding this comment.
and add the issue link here as well?
There was a problem hiding this comment.
tokumori
pushed a commit
to AlohaSafe/gaen-mobile
that referenced
this pull request
Dec 31, 2020
…#744) Why: we would like for the user details form to provide a good UX on both iOS and Android. This commit: Updates the styling on the form, especially to the DatePicker element. Note that ReactNativeDatetimePicker has a UI bug on android that required an odd workaround with `setShowDatePickerAndroid(false)` reference: react-native-datetimepicker/datetimepicker#263 react-native-datetimepicker/datetimepicker#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: we would like for the user details form to provide a good UX on both iOS and Android.