Skip to content

Commit

Permalink
Improvement/Add-external-links (#947)
Browse files Browse the repository at this point in the history
* Add new context and component folder refactor, adds external link component
* Prettify
* Fix factories
  • Loading branch information
mxMarkowitz authored Dec 7, 2021
1 parent aff6f63 commit dfc6472
Show file tree
Hide file tree
Showing 55 changed files with 313 additions and 169 deletions.
2 changes: 1 addition & 1 deletion App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
OnboardingProvider,
determineIsOnboardingComplete,
} from "./src/OnboardingContext"
import { ConfigurationProvider } from "./src/ConfigurationContext"
import { ConfigurationProvider } from "./src/configuration/configurationProvider";
import { PermissionsProvider } from "./src/Device/PermissionsContext"
import { initializei18next, loadUserLocale } from "./src/locales/languages"
import Logger from "./src/logger"
Expand Down
3 changes: 3 additions & 0 deletions example.env.bt
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ DISPLAY_DEBUG_MENU=false
DISPLAY_COVID_DATA=false
STATE_ABBREVIATION=
COVID_ACT_NOW_API_KEY=
EXTERNAL_COVID_DATA_LINK=https://google.com
EXTERNAL_COVID_DATA_LABEL=Covid Data Label
EXTERNAL_TRAVEL_GUIDENCE_LINK="https://maps.google.com

// Age Verification
DISPLAY_AGE_VERIFICATION=true
Expand Down
2 changes: 1 addition & 1 deletion src/Activation/AcceptTermsOfService.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useNavigation } from "@react-navigation/native"
import { Linking } from "react-native"

import AcceptTermsOfService from "./AcceptTermsOfService"
import { ConfigurationContext } from "../ConfigurationContext"
import { ConfigurationContext } from "../configuration"
import { factories } from "../factories"
import { OnboardingProvider } from "../OnboardingContext"

Expand Down
2 changes: 1 addition & 1 deletion src/Activation/AcceptTermsOfService.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { SvgXml } from "react-native-svg"
import { Icons } from "../assets"
import { Text } from "../components"
import { useStatusBarEffect } from "../navigation"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { useActivationNavigation } from "./useActivationNavigation"

import {
Expand Down
2 changes: 1 addition & 1 deletion src/Activation/ProductAnalyticsConsentForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from "react-native"
import { useTranslation } from "react-i18next"

import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { useProductAnalyticsContext } from "../ProductAnalytics/Context"
import { useStatusBarEffect } from "../navigation"
import { useCustomCopy } from "../configuration/useCustomCopy"
Expand Down
2 changes: 1 addition & 1 deletion src/Activation/useActivationNavigation.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Platform } from "react-native"
import { useNavigation } from "@react-navigation/native"

import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import {
ENPermissionStatus,
usePermissionsContext,
Expand Down
2 changes: 1 addition & 1 deletion src/AffectedUserFlow/CodeInput/CodeInputForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
AffectedUserFlowStackScreens,
} from "../../navigation"
import Logger from "../../logger"
import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"

import {
Spacing,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useStatusBarEffect } from "../../navigation"
import { useAffectedUserContext } from "../AffectedUserContext"
import PublishConsentForm from "./PublishConsentForm"
import { useExposureContext } from "../../ExposureContext"
import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"

import { Colors } from "../../styles"

Expand Down
2 changes: 1 addition & 1 deletion src/AffectedUserFlow/Start.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { Text } from "../components"

import { Spacing, Colors, Typography, Buttons, Iconography } from "../styles"
import { Icons, Images } from "../assets"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

export const AffectedUserFlowIntro: FunctionComponent = () => {
useStatusBarEffect("dark-content", Colors.background.primaryLight)
Expand Down
6 changes: 3 additions & 3 deletions src/AffectedUserFlow/SymptomOnsetDate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import StaticSafeAreaInsets from "react-native-static-safe-area-insets"

import { AffectedUserFlowStackScreens, useStatusBarEffect } from "../navigation"
import { useAffectedUserContext } from "./AffectedUserContext"
import Checkbox from "../components/Checkbox"
import { CheckBox } from "../components"

import { Buttons, Colors, Forms, Spacing, Typography } from "../styles"
import { Icons } from "../assets"
Expand Down Expand Up @@ -131,14 +131,14 @@ const SymptomOnsetDate: FunctionComponent = () => {
{t("export.symptom_onset.did_you_have_symptoms")}
</Text>
<View style={noSymptomsContainerStyle}>
<Checkbox
<CheckBox
label={t("export.symptom_onset.no_i_didnt_have")}
onPress={handleOnPressNoSymptoms}
checked={Boolean(!localSymptomOnsetDate)}
/>
</View>
<View style={hasSymptomsContainerStyle}>
<Checkbox
<CheckBox
label={t("export.symptom_onset.yes_i_did_have")}
onPress={handleOnPressHasSymptoms}
checked={Boolean(localSymptomOnsetDate)}
Expand Down
2 changes: 1 addition & 1 deletion src/AffectedUserFlow/VerificationCodeInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { SvgXml } from "react-native-svg"
import env from "react-native-config"

import { Text } from "../components"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

import { Spacing, Typography, Colors, Buttons } from "../styles"
import { Icons } from "../assets"
Expand Down
2 changes: 1 addition & 1 deletion src/CallEmergencyServices.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import { useTranslation } from "react-i18next"
import { SvgXml } from "react-native-svg"

import { useConfigurationContext } from "./ConfigurationContext"
import { useConfigurationContext } from "./configuration"
import { Text } from "./components"

import { Buttons, Colors, Iconography, Spacing, Typography } from "./styles"
Expand Down
2 changes: 1 addition & 1 deletion src/Callback/Form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { useCustomCopy } from "../configuration/useCustomCopy"
import { LoadingIndicator, Text } from "../components"
import * as API from "./callbackAPI"
import Logger from "../logger"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

import { Spacing, Forms, Colors, Typography, Buttons } from "../styles"

Expand Down
2 changes: 1 addition & 1 deletion src/CovidData/Context.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { Text } from "react-native"
import { render, waitFor } from "@testing-library/react-native"

import { factories } from "../factories"
import { ConfigurationContext } from "../ConfigurationContext"
import { ConfigurationContext } from "../configuration"
import { useCovidDataContext, CovidDataContextProvider } from "./Context"
import { fetchStateTimeseries } from "./API/covidActNow"

Expand Down
2 changes: 1 addition & 1 deletion src/CovidData/Context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import React, {
useCallback,
useContext,
} from "react"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

import * as CovidData from "./covidData"
import { fetchStateTimeseries, NetworkResponse } from "./API/covidActNow"
Expand Down
2 changes: 1 addition & 1 deletion src/CovidData/Dashboard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import { useTranslation } from "react-i18next"
import StaticSafeAreaInsets from "react-native-static-safe-area-insets"

import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"
import { Text } from "../../components"
import { useCovidDataContext } from "../Context"
import StateData from "./StateData"
Expand Down
2 changes: 1 addition & 1 deletion src/CovidRecommendation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { SvgXml } from "react-native-svg"

import { useStatusBarEffect } from "./navigation"
import { Text } from "./components"
import { useConfigurationContext } from "./ConfigurationContext"
import { useConfigurationContext } from "./configuration"

import { Buttons, Colors, Spacing, Typography } from "./styles"
import { Images, Icons } from "./assets"
Expand Down
2 changes: 1 addition & 1 deletion src/EscrowVerification/Complete.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { SvgXml } from "react-native-svg"

import { StatusBar, Text } from "../components"
import { useStatusBarEffect, Stacks } from "../navigation"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import Logger from "../logger"

import { Images, Icons } from "../assets"
Expand Down
2 changes: 1 addition & 1 deletion src/EscrowVerification/MoreInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { useCustomCopy } from "../configuration/useCustomCopy"
import { SvgXml } from "react-native-svg"

import { Text } from "../components"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

import { Spacing, Typography, Colors, Buttons } from "../styles"
import { Icons } from "../assets"
Expand Down
2 changes: 1 addition & 1 deletion src/ExposureHistory/History/HasExposures.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { FunctionComponent } from "react"
import { StyleSheet, View } from "react-native"
import { useTranslation } from "react-i18next"

import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"
import { ExposureDatum } from "../../exposure"
import ExposureListItem from "./ExposureListItem"
import ExposureSummary from "./ExposureSummary"
Expand Down
2 changes: 1 addition & 1 deletion src/ExposureHistory/History/NextSteps.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { useProductAnalyticsContext } from "../../ProductAnalytics/Context"

import { Buttons, Colors, Spacing, Typography } from "../../styles"
import { Icons } from "../../assets"
import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"

type Posix = number

Expand Down
2 changes: 1 addition & 1 deletion src/ExposureHistory/History/NoExposures.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React from "react"
import { render, cleanup, fireEvent } from "@testing-library/react-native"
import NoExposures from "./NoExposures"
import { Linking } from "react-native"
import { ConfigurationContext } from "../../ConfigurationContext"
import { ConfigurationContext } from "../../configuration"
import { factories } from "../../factories"

afterEach(cleanup)
Expand Down
2 changes: 1 addition & 1 deletion src/ExposureHistory/History/NoExposures.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { SvgXml } from "react-native-svg"
import { useTranslation } from "react-i18next"

import { Text } from "../../components"
import { useConfigurationContext } from "../../ConfigurationContext"
import { useConfigurationContext } from "../../configuration"

import { Outlines, Colors, Typography, Spacing, Buttons } from "../../styles"
import { Icons } from "../../assets"
Expand Down
2 changes: 1 addition & 1 deletion src/Home/index.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import "@testing-library/jest-native/extend-expect"
import Home from "./index"
import { HomeStackScreens } from "../navigation"
import { factories } from "../factories"
import { ConfigurationContext } from "../ConfigurationContext"
import { ConfigurationContext } from "../configuration"
import { PermissionsContext } from "../Device/PermissionsContext"

jest.mock("@react-navigation/native")
Expand Down
22 changes: 21 additions & 1 deletion src/Home/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
EscrowVerificationRoutes,
useStatusBarEffect,
} from "../navigation"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { StatusBar, Text } from "../components"

import CovidDataCard from "../CovidData/Card"
Expand All @@ -43,6 +43,7 @@ import {
Iconography,
Buttons,
} from "../styles"
import { ExternalLink } from "../components/ExternalLink"

const IMAGE_HEIGHT = 170

Expand All @@ -57,6 +58,9 @@ const Home: FunctionComponent = () => {
displaySelfAssessment,
displaySymptomHistory,
emergencyPhoneNumber,
externalCovidDataLink,
externalCovidDataLabel,
externalTravelGuidanceLink,
healthAuthorityHealthCheckUrl,
verificationStrategy,
} = useConfigurationContext()
Expand All @@ -81,6 +85,22 @@ const Home: FunctionComponent = () => {
<HealthCheckLink healthCheckUrl={healthAuthorityHealthCheckUrl} />
)}
{displayCovidDataWebView && <CovidDataWebViewLink />}
{externalCovidDataLink && (
<ExternalLink
icon={Icons.QuestionMark}
label={t("home.covid_data_specific", {
label: externalCovidDataLabel,
})}
link={externalCovidDataLink}
/>
)}
{externalTravelGuidanceLink && (
<ExternalLink
icon={Icons.QuestionMark}
label={t("home.safe_travel_guidence")}
link={externalTravelGuidanceLink}
/>
)}
{appDownloadUrl && <ShareLink appDownloadUrl={appDownloadUrl} />}
{env.VERIFICATION_CODE_INFO_URL && <FaqButton />}
{displaySelfAssessment && <SelfAssessment />}
Expand Down
2 changes: 1 addition & 1 deletion src/Onboarding/useOnboardingNavigation.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { useNavigation } from "@react-navigation/native"

import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import {
OnboardingRoutes,
Stacks,
Expand Down
2 changes: 1 addition & 1 deletion src/SelfAssessment/Guidance.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { SvgXml } from "react-native-svg"

import { StatusBar, Text } from "../components"
import { useSelfAssessmentContext } from "./Context"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { SymptomGroup } from "./selfAssessment"
import { Stack, Stacks, useStatusBarEffect } from "../navigation"

Expand Down
2 changes: 1 addition & 1 deletion src/SelfAssessment/SelfAssessmentIntro.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { SvgXml } from "react-native-svg"
import { useCustomCopy } from "../configuration/useCustomCopy"
import { SelfAssessmentStackScreens, useStatusBarEffect } from "../navigation"
import { Text } from "../components"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"

import { Icons, Images } from "../assets"
import { Buttons, Colors, Outlines, Spacing, Typography } from "../styles"
Expand Down
2 changes: 1 addition & 1 deletion src/Settings/DeleteConfirmation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { showMessage } from "react-native-flash-message"
import { useOnboardingContext } from "../OnboardingContext"
import { useProductAnalyticsContext } from "../ProductAnalytics/Context"
import { useSymptomHistoryContext } from "../SymptomHistory/SymptomHistoryContext"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { useApplicationName } from "../Device/useApplicationInfo"
import { resetUserLocale } from "../locales/languages"

Expand Down
2 changes: 1 addition & 1 deletion src/Settings/Legal.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import "@testing-library/jest-native/extend-expect"
import { useNavigation, useFocusEffect } from "@react-navigation/native"

import { useApplicationName } from "../Device/useApplicationInfo"
import { ConfigurationContext } from "../ConfigurationContext"
import { ConfigurationContext } from "../configuration"
import { factories } from "../factories"
import {
loadAuthorityLinks,
Expand Down
2 changes: 1 addition & 1 deletion src/Settings/Legal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ScrollView, StyleSheet } from "react-native"
import { useTranslation } from "react-i18next"

import { useApplicationName } from "../Device/useApplicationInfo"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import ExternalLink from "./ExternalLink"
import { useCustomCopy } from "../configuration/useCustomCopy"
import {
Expand Down
2 changes: 1 addition & 1 deletion src/Settings/ProductAnalyticsConsentScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
import { useNavigation } from "@react-navigation/native"
import { useTranslation } from "react-i18next"

import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { useProductAnalyticsContext } from "../ProductAnalytics/Context"
import { useStatusBarEffect } from "../navigation"
import { useCustomCopy } from "../configuration/useCustomCopy"
Expand Down
2 changes: 1 addition & 1 deletion src/Settings/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
SettingsStackScreens,
HowItWorksStackScreens,
} from "../navigation"
import { useConfigurationContext } from "../ConfigurationContext"
import { useConfigurationContext } from "../configuration"
import { Text, ListItem, ListItemSeparator, StatusBar } from "../components"
import { useApplicationInfo } from "../Device/useApplicationInfo"
import ExternalLink from "../Settings/ExternalLink"
Expand Down
6 changes: 3 additions & 3 deletions src/SymptomHistory/Form/SelectSymptoms.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
hasEmergencySymptoms,
SymptomEntry,
} from "../symptomHistory"
import Checkbox from "../../components/Checkbox"
import { CheckBox } from "../../components"

import {
Affordances,
Expand Down Expand Up @@ -117,7 +117,7 @@ const SelectSymptomsForm: FunctionComponent<SelectSymptomsFormProps> = ({
<View style={style.symptomButtonsContainer}>
{showNoSymptoms ? (
<View style={style.noSymptomsCheckbox}>
<Checkbox
<CheckBox
key={"no_symptoms"}
label={t("symptom_history.no_symptoms")}
onPress={handleOnPressNoSymptoms}
Expand All @@ -128,7 +128,7 @@ const SelectSymptomsForm: FunctionComponent<SelectSymptomsFormProps> = ({
{Symptom.all.map((symptom: Symptom.Symptom) => {
const translation = Symptom.toTranslation(t, symptom)
return (
<Checkbox
<CheckBox
key={symptom}
label={translation}
onPress={() => handleOnPressSymptom(symptom)}
Expand Down
Loading

0 comments on commit dfc6472

Please sign in to comment.