Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delays the binding to selected message property #750

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

HEskandari
Copy link
Contributor

Resolves #721

WilliamBZA
WilliamBZA previously approved these changes Sep 1, 2017
@adamralph
Copy link
Contributor

@ramonsmits as the original requester of this change, would you mind trying out this branch to see if it solves the problem adequately? Note that the current delay is 100ms, but we've also been experimenting with 50ms, to see what's better. Please could you test both values and let us know what you prefer.

Copy link
Contributor

@adamralph adamralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We just need to finalise what the exact delay should be. Marking as WIP.

@adamralph adamralph changed the title Delays the binding to selected message property [WIP] Delays the binding to selected message property Sep 5, 2017
@HEskandari
Copy link
Contributor Author

@adamralph Changed the delay to 50ms. Please merge if there's nothing else.

@adamralph adamralph changed the title [WIP] Delays the binding to selected message property Delays the binding to selected message property Sep 19, 2017
@adamralph adamralph merged commit d43c37e into master Sep 19, 2017
@adamralph adamralph deleted the delayed-selection-change branch September 19, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants