Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in plugin loading and error handling #1006

Merged
merged 4 commits into from
Feb 15, 2021
Merged

Improvements in plugin loading and error handling #1006

merged 4 commits into from
Feb 15, 2021

Conversation

HEskandari
Copy link
Contributor

Resolves #999

This does a few things related to plugins:

  • Better error handling so if the plugin fails to start, the application still works
  • Logs plugin error to the Logs Window. Also logs a successful load to that window.
  • Allows loading assemblies that start with Microsoft and System

@HEskandari HEskandari changed the title Plugin check Improvements in plugin loading and error handling Feb 12, 2021
@HEskandari HEskandari added this to the 2.6.0 milestone Feb 15, 2021
@HEskandari HEskandari merged commit b4ffb25 into master Feb 15, 2021
@HEskandari HEskandari deleted the plugin-check branch February 15, 2021 00:54
@HEskandari HEskandari removed this from the 2.6.0 milestone Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauroservienti mauroservienti mauroservienti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create plugins with a reference to System or Microsoft assemblies
2 participants
@HEskandari @mauroservienti