Known endpoints relative URI #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
relative-uri-known-endpoints
branch
from
cc52452 to
1a0558e
Compare
danielmarbach
force-pushed
the
relative-uri-known-endpoints
branch
from
1a0558e to
796097a
Compare
SzymonPobiega
approved these changes
Feb 22, 2018
adamralph
approved these changes
Feb 22, 2018
|
FYI I've smoke tested this against the currently-being-patched SI and it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion on Particular/ServiceInsight#787 @adamralph and I think the new API endpoint should be relative. SI uses the connection string provided in the API and then can just add the relative part to the URI