-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating build action to include provenance #182
base: master
Are you sure you want to change the base?
Conversation
Replaced multiple tagging commands with a single one
Invoke-Expression $cmd | ||
Write-Output "::endgroup::" | ||
} | ||
$tagsCLI = $tags -replace "^", "--tag particular/servicecontrol-masstransit-connector:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced multiple commands with a single command
run: echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
uses: docker/login-action@v3 | ||
with: | ||
registry: ghcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the Github action to authenticate to Github registry
docker buildx imagetools inspect ghcr.io/particular/servicecontrol-masstransit-connector:${{ env.TAG_NAME }} | ||
uses: docker/login-action@v3 | ||
with: | ||
registry: ghcr.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the Github action to authenticate to Github registry
id: date | ||
run: echo "::set-output name=date::$(date +'+%FT%TZ')" | ||
- name: Build and push image to GitHub container registry | ||
uses: docker/build-push-action@v6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Github action to push and tag image.
This will use provenance
74b4a22
to
0b38e43
Compare
Using build-push-action instead of script This adds the provenance by default, see https://docs.docker.com/build/ci/github-actions/attestations/#default-provenance This given the image a better score in dockerhub scout health score
0b38e43
to
6eddac1
Compare
This is to fix
![image](https://private-user-images.githubusercontent.com/122651/411388093-7bd24e97-1e59-4034-b0b5-e6c141ba4623.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjQwMDcsIm5iZiI6MTczOTMyMzcwNywicGF0aCI6Ii8xMjI2NTEvNDExMzg4MDkzLTdiZDI0ZTk3LTFlNTktNDAzNC1iMGI1LWU2YzE0MWJhNDYyMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwMTI4MjdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZjNjYTA3ZWUzNzBmZGMwNmUxZTcxZGU1NzM3YTUwZGI5MzhhYjVjZTAzMmI3N2JiZDJiNDJhZjc3OGFlNDU4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YJo4UskL93YCYPAj1TaftL054wIMLUXWhUymXwZOO9c)