Complete synchronized storage session before storing outbox data #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbussmann
requested review from
danielmarbach,
SzymonPobiega and
lailabougria
SzymonPobiega
approved these changes
Apr 28, 2023
danielmarbach
approved these changes
Apr 28, 2023
src/NServiceBus.TransactionalSession.Tests/OutboxTransactionalSessionTests.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.TransactionalSession.Tests/OutboxTransactionalSessionTests.cs
Outdated
Show resolved
Hide resolved
timbussmann
added a commit
that referenced
this pull request
May 1, 2023
timbussmann
added a commit
that referenced
this pull request
May 1, 2023
* Complete synchronized storage session before storing outbox data (#191) * Fix packages not uploading on CI runs * update testing references
timbussmann
added a commit
that referenced
this pull request
May 1, 2023
* add test * complete session before storing outbox operations * Apply suggestions from code review --------- Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
danielmarbach
added a commit
that referenced
this pull request
May 1, 2023
* Complete synchronized storage session before storing outbox data (#191) * add test * complete session before storing outbox operations * Apply suggestions from code review --------- Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> * Fix packages not uploading on CI runs * Acceptance test to verify core vs transactional session behavior (#193) * update testing packages --------- Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> Co-authored-by: David Boike <david.boike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
This is more aligned with Core's behavior in the incoming pipeline, where the session is completed in the LoadHandlersConnector while the outbox
Storeoperations happens in the TransportReceiveToPhysicalMessageConnector afterwards.