Rework mapping api (#295) #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New interfaces for better segregation * Start reworking the API (WIP) * Further refactoring and splitting responsibilities * Fix the behavior tests * Fix the partition key extractor tests * Make things compile again * Remove the old interface and approve the API * More adjustments * Add TODOs for Bob * Added header overloads to TransactionInformationConfiguration * Add extract CI from all headers and partial file for readability * Add extract CI from headers and partial file for readability * Skeleton extractor tests * Partial of PartitionKeyExtractor * ContainerInformation Header argument rename * Some container information extractor tests * Make sure we don't miss exposing extraction APIs * Expose missing APIs * Fix test * Approve API * Additional overloads and test coverage * More test coverage and tweak to exception message * Container API covered by acceptance test * Coverage of logical container extraction * More acceptance test coverage * For the from headers cases allow the returned struct to be null Add test coverage for the scenarios in docs Remove some TODOs * Unit test for null returns * Cleanup and documentation * Fix test * Rename the container acceptance tests to di Co-authored-by: Bob Langley <bob.langley@particular.net> # Conflicts: # src/NServiceBus.Persistence.CosmosDB.LogicalOutbox.AcceptanceTests/ConfigureEndpointCosmosDBPersistence.cs # src/NServiceBus.Persistence.CosmosDB.LogicalOutbox.AcceptanceTests/When_custom_partition_key_extractor_from_message_registered_via_di.cs # src/NServiceBus.Persistence.CosmosDB.PhysicalOutbox.AcceptanceTests/ConfigureEndpointCosmosDBPersistence.cs # src/NServiceBus.Persistence.CosmosDB.PhysicalOutbox.AcceptanceTests/When_custom_partition_key_extractor_from_headers_registered_via_di.cs # src/NServiceBus.Persistence.CosmosDB/Transaction/TransactionInformationBeforeTheLogicalOutboxBehavior.cs # src/NServiceBus.Persistence.CosmosDB/Transaction/TransactionInformationBeforeThePhysicalOutboxBehavior.cs
timbussmann
approved these changes
Jan 18, 2022
boblangley
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #69
Brings back #295 to
release-1.1