Merge pull request #199 from Particular/backport-throw

Throw if endpoint configured for message-driven pub/sub
Particular · Jul 29, 2021 · 1591c17 · 1591c17
2 parents f8da320 + fb937f2
commit 1591c17
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/NServiceBus.Persistence.CosmosDB/NServiceBus.Persistence.CosmosDB.csproj b/src/NServiceBus.Persistence.CosmosDB/NServiceBus.Persistence.CosmosDB.csproj
@@ -9,7 +9,7 @@
   <ItemGroup>
     <PackageReference Include="Particular.Packaging" Version="1.2.1" PrivateAssets="All" />
     <PackageReference Include="NServiceBus" Version="[7.1.10, 8.0.0)" />
-    <PackageReference Include="Microsoft.Azure.Cosmos" Version="[3.15.0, 4)" />
+    <PackageReference Include="Microsoft.Azure.Cosmos" Version="[3.20.1, 4)" />
   </ItemGroup>
 
-</Project>
+</Project>
diff --git a/src/NServiceBus.Persistence.CosmosDB/Outbox/OutboxStorage.cs b/src/NServiceBus.Persistence.CosmosDB/Outbox/OutboxStorage.cs
@@ -19,6 +19,8 @@ class OutboxStorage : Feature
 
         protected override void Setup(FeatureConfigurationContext context)
         {
+            NonNativePubSubCheck.ThrowIfMessageDrivenPubSubInUse(context);
+
             var serializer = new JsonSerializer { ContractResolver = new UpperCaseIdIntoLowerCaseIdContractResolver() };
 
             var ttlInSeconds = context.Settings.Get<int>(SettingsKeys.OutboxTimeToLiveInSeconds);

diff --git a/src/NServiceBus.Persistence.CosmosDB/Saga/SagaPersistence.cs b/src/NServiceBus.Persistence.CosmosDB/Saga/SagaPersistence.cs
@@ -19,6 +19,8 @@ internal CosmosDbSagaPersistence()
 
         protected override void Setup(FeatureConfigurationContext context)
         {
+            NonNativePubSubCheck.ThrowIfMessageDrivenPubSubInUse(context);
+
             var serializer = new JsonSerializer { ContractResolver = new UpperCaseIdIntoLowerCaseIdContractResolver() };
 
             var migrationModeEnabled = context.Settings.GetOrDefault<bool>(SettingsKeys.EnableMigrationMode);

diff --git a/src/NServiceBus.Persistence.CosmosDB/Utility/NonNativePubSubCheck.cs b/src/NServiceBus.Persistence.CosmosDB/Utility/NonNativePubSubCheck.cs
@@ -0,0 +1,16 @@
+namespace NServiceBus.Persistence.CosmosDB
+{
+    using System;
+    using NServiceBus.Features;
+
+    class NonNativePubSubCheck
+    {
+        public static void ThrowIfMessageDrivenPubSubInUse(FeatureConfigurationContext context)
+        {
+            if (context.Settings.IsFeatureEnabled(typeof(MessageDrivenSubscriptions)) || context.Settings.IsFeatureActive(typeof(MessageDrivenSubscriptions)))
+            {
+                throw new Exception("NServiceBus.Persistence.CosmosDB must be used with a transport that provides native publish/subscribe capabilities, and cannot be used with message-driven publish/subscribe.");
+            }
+        }
+    }
+}