866: removed the code that tries to list the topics with each dispatc…

[Selimmo]

Because of the issue #866

The code that is removed (line 247 to 256) was causing many failures, it is causing each dispatch to go and ListTopics which has a 30 transactions per second Hard limit.

we first downloaded the code to our repo and used it instead of 5.3.1 nuget package, and all the tests started to succeed.

was hoping to speed this up a little by creating the PR (we can maybe create a new release 5.4)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Mohamed Mohamed seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[WilliamBZA]

@ramonsmits This is related to #866, can you take a look?

[ramonsmits]

@Selimmo The code removed the lookup but from what I understood it existed to detect incorrectly configured SQS configurations. This PR would make sense if we would drop prior configurations but that would be a breaking change and would require a new major version.

The team what will resolve the issue once prioritized and staffed will definitely look at this PR but we can't merge this as is as a new minor or major.

[Selimmo]

Thanks @ramonsmits

I was wondering if you or someone could give some more details on "incorrectly configured SQS configurations"? maybe an example of such incorrect configuration would be great.

we can also modify this code to Opt-out so the developer (i.e. us) can choose not to have this function if we are confident that it will not be incorrectly configured in our environment?

we are in this situation because of AWS hard limit with ListTopics and due to that i feel the current implementation is not Fit for purpose.

Thanks
Mo

[ramonsmits]

I was wondering if you or someone could give some more details on "incorrectly configured SQS configurations"? maybe an example of such incorrect configuration would be great.

@Selimmo It's connected to the message-driven pub/sub hybrid mode. If the message we're trying to dispatch is a unicast message with a Publish intent but the subscriber is also subscribed via SNS we don't want to dispatch the message twice, the subscriber will receive it via SNS and not via a unicast send.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.