Use wildcard format as documented by AWS to fix native integration wh…

…en using localstack instead of real AWS cloud (#2289) (#2298)

* Update requested MessageAttributeNames to match the wildcard in the AWS SQS docs

* Adjust tests to the new wildcard format

* Consistently use All

---------

Co-authored-by: Maddie Hermann <46518526+maddiehermann@users.noreply.github.com>
Co-authored-by: danielmarbach <daniel.marbach@openplace.net>

src/NServiceBus.Transport.SQS.AcceptanceTests/NativeIntegration/NativeEndpoint.cs

@@ -28,7 +28,7 @@ public static async Task ConsumePoisonQueue(Guid testRunId, string errorQueueAdd
                 {
                     QueueUrl = getQueueUrlResponse.QueueUrl,
                     WaitTimeSeconds = 5,
-                    MessageAttributeNames = new List<string> { "*" }
+                    MessageAttributeNames = new List<string> { "All" }
                 }, cancellationToken).ConfigureAwait(false);
 
                 foreach (var msg in receiveMessageResponse.Messages)

src/NServiceBus.Transport.SQS.Tests/InputQueuePumpTests.cs

@@ -57,7 +57,7 @@ public async Task Start_loops_until_canceled()
 
             Assert.IsTrue(mockSqsClient.ReceiveMessagesRequestsSent.All(r => r.MaxNumberOfMessages == 1), "MaxNumberOfMessages did not match");
             Assert.IsTrue(mockSqsClient.ReceiveMessagesRequestsSent.All(r => r.QueueUrl == FakeInputQueueQueueUrl), "QueueUrl did not match");
-            Assert.IsTrue(mockSqsClient.ReceiveMessagesRequestsSent.All(r => r.MessageAttributeNames.SequenceEqual(new List<string> { "*" })), "MessageAttributeNames did not match");
+            Assert.IsTrue(mockSqsClient.ReceiveMessagesRequestsSent.All(r => r.MessageAttributeNames.SequenceEqual(new List<string> { "All" })), "MessageAttributeNames did not match");
             Assert.IsTrue(mockSqsClient.ReceiveMessagesRequestsSent.All(r => r.AttributeNames.SequenceEqual(new List<string> { "SentTimestamp" })), "AttributeNames did not match");
         }
 

src/NServiceBus.Transport.SQS/InputQueuePump.cs

@@ -126,7 +126,7 @@ public Task StartReceive(CancellationToken cancellationToken = default)
                 QueueUrl = inputQueueUrl,
                 WaitTimeSeconds = 20,
                 AttributeNames = new List<string> { "SentTimestamp" },
-                MessageAttributeNames = new List<string> { "*" }
+                MessageAttributeNames = new List<string> { "All" }
             };
 
             if (coreSettings != null && coreSettings.TryGet<int>(SettingsKeys.MessageVisibilityTimeout, out var visibilityTimeout))