New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add `SearchBuilder` #9

Merged

ParthJadhav merged 26 commits into ParthJadhav:master from TheAwiteb:fix-6

Nov 5, 2022

Contributor

TheAwiteb commented Oct 30, 2022 •

edited

Loading

This will closes #6

~~There is no BC, so you can release minor version.~~ there is

This will help us add features, such as making the user control whether git ignore and hidden files are shown, and for example adding a feature to search without looking at letter case, all without BC

TheAwiteb added 7 commits

October 30, 2022 19:43


          Move the Search struct to search.rs and the regex util to utils.rs

c8d87e5


          Rename argument file_type -> file_ext

6e4bc0e


          Docs for new function

26df30e


          Add SearchBuilder struct`

144d3c9

This struct will make build `Search` easier


          Export SearchBuilder

d67cc63


          Use default from SearchBuilder

1f926b0


          Label search::new as deprecated

0513f93

Because modifying it will cause BC so it is better to use `SearchBuilder`

This was referenced Oct 30, 2022

Replace ~ with home directory in unix-like system #11

Closed

Receiving the file extension without a dot #10

Closed


          Update README.md

e9343f1

Change examples to use `SearchBuilder`, also some improvements

ParthJadhav reviewed

View reviewed changes

src/search.rs Outdated Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/utils.rs Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/builder.rs Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/builder.rs Outdated Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/builder.rs Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/builder.rs Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

src/builder.rs Outdated Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

ParthJadhav reviewed

View reviewed changes

Owner

ParthJadhav left a comment

Sorry for lot of questions @TheAwiteb 😄

Contributor Author

TheAwiteb commented Nov 1, 2022 •

edited

Loading

Sorry for lot of questions 😄

No, no problem. I'll work on requests change today

TheAwiteb added 3 commits

November 1, 2022 23:04


          Rename input SearchBuilder instance function to search_input

b37701b


          SearchBuilder docs improvment

2dd72c8


          Update README.md

682eae8

Make exampels returns `Vec<String>`

TheAwiteb requested a review from ParthJadhav

November 1, 2022 20:10

ParthJadhav approved these changes

View reviewed changes

Owner

ParthJadhav left a comment

Awesome, Tested it and it works great.

Just this seems to be off 😄


          feat: add strict search option

ae8cbc9

defaults to: false

ParthJadhav mentioned this pull request

feat: add fuzzy text search support #5

Closed

ParthJadhav added 2 commits

November 5, 2022 14:49


          feat: add ignore case option & improve code quality

35cda6a


          feat: add hidden search option

33e9d7a

ParthJadhav added 3 commits

November 5, 2022 16:39


          Merge branch 'master' into fix-6

053caab


          chore: add docs

1ce187c


          Merge branch 'fix-6' of https://github.com/TheAwiteb/rust_search into…

200417e

… pr/9

Owner

ParthJadhav commented Nov 5, 2022

@TheAwiteb can you review the new additions ?

ParthJadhav assigned ParthJadhav and TheAwiteb

ParthJadhav added the enhancement label

Contributor Author

TheAwiteb commented Nov 5, 2022

I will fix somethings, and I will write a description explaining the reason for the modification for each commit

Owner

ParthJadhav commented Nov 5, 2022

Okay, thanks @TheAwiteb .

TheAwiteb added 8 commits

November 5, 2022 15:30


          Rustfmt

a1ed3de


          Use if let

0c3b3f5


          Remove deprecated attr

Because there is BC on `new` function


          Allow too many arguments in Search::new function

03bd0c1


          Make Option<bool> -> bool

bc6cefc


          Update function using

a294679


          Add defult of strict in docs

558ebd1


          Update examples

99fb936

Contributor Author

TheAwiteb commented Nov 5, 2022

Lots of changes. Ask me if something is not understood

Contributor Author

TheAwiteb commented Nov 5, 2022

Also there is BC, so we need to versioning 1.0.0

ParthJadhav approved these changes

View reviewed changes

Owner

ParthJadhav left a comment

Amazing !! LGTM

Owner

ParthJadhav commented Nov 5, 2022 •

edited

Loading

The code compiles & runs but why does it throw this Error?

Contributor Author

TheAwiteb commented Nov 5, 2022

The code compiles & runs but why does it throw this Error?

Did you pull new changes?

Owner

ParthJadhav commented Nov 5, 2022

Yep

Contributor Author

TheAwiteb commented Nov 5, 2022

Yep

I don't think that

Owner

ParthJadhav commented Nov 5, 2022

I pulled the changes, But I guess Rust_Analyser takes some time to get all the parameters ready.

Owner

ParthJadhav commented Nov 5, 2022

Tested it and Works well ! Let's merge it 🎊

Owner

ParthJadhav commented Nov 5, 2022

Thanks @TheAwiteb for amazing changes & refactoring

ParthJadhav merged commit 288433e into ParthJadhav:master

TheAwiteb deleted the fix-6 branch

November 5, 2022 14:13

TheAwiteb mentioned this pull request

[Bug]: Search work without file extension, but with it's not #4

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels