Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#63 fix orientation issue in sdk 26 #74

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

JSpiner
Copy link
Contributor

@JSpiner JSpiner commented Jan 9, 2018

related with #63

Since android 'O'(26), we should satisfy following condition.

if (ActivityInfo.isFixedOrientation(requestedOrientation) && !fullscreen
                 && appInfo.targetSdkVersion >= O) {
             throw new IllegalStateException("Only fullscreen activities can request orientation");
         }

(detail info is here )

We don't know which direction the application using this library will use.
So we should support all direction.
And it should be able to change when the user needs it.

So, I changed TedPermissionActivity's screen orientation to unspecified.
And create setScreenOrientation method at PermissionBuilder

thanks to @andreas-

@ParkSangGwon
Copy link
Owner

LGTM

@ParkSangGwon ParkSangGwon merged commit 842b86f into ParkSangGwon:master Feb 6, 2018
@ted-prnd ted-prnd mentioned this pull request Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants