Adding a authorities/responsabilities models #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @AnasGhrab for this PR. I will review it next week. |
yomguy
requested changes
Jul 1, 2020
There was a problem hiding this comment.
Hi @AnasGhrab, review done. As commented, I think you should update the on_delete parameters to avoid before we can merge. Everything else is really fine, thanks! 👎
| authority = models.ForeignKey('Authority', on_delete = models.CASCADE) | ||
| role = models.ForeignKey('Role', on_delete = models.CASCADE) | ||
| item = models.ForeignKey('MediaItem', on_delete = models.CASCADE) | ||
| collection = models.ForeignKey('MediaCollection', on_delete = models.CASCADE) |
There was a problem hiding this comment.
For those 4 fields, to avoid cascade deleting, I strongly advise to set on_delete=models.SET_NULL.
If not, in this case and for example, a Responsability could be deleted when the related Role or Item is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a better management of persons and related informations.