fixes mantis blade implant surgery #28073
Open
+0
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes #28071
Removes an internal organ check that prevented Mantis Blades from being both implanted. It checked the target mob's internal organs and since the mantis blades share a path (unless the mantis_blade/l variant is created by an admin), it prevented the 2nd one from being installed, despite being different from the right one.
All organs and implants appear to have assigned slots already, so trying to implant a 2nd brain in the head will get caught by an earlier check. This PR will make it possible for limb agnostic implants (think 2 tool-set implants, one in the left and one in the right arm) to be implanted in the same person, though I don't see much benefit in doing that.
Positronic brains don't have a slot, but they have a dedicated check for an existing brain in robotics.dm
Why It's Good For The Game
Mantis blade implant surgery works now. Allows other implants with similar mechanics to the mantis blades to be implantable too.
Testing
Spawned 2 right arm mantis blades, screwdrivered one. Tried implanting them in the same arm, in the wrong arm and it failed. Successfully implanted them in their respective arms.
Checked how many organs I can fit in an IPC. The answer is the same as before.
Declaration
Changelog
🆑
fix: mantis blade implant surgery works now
/:cl: