Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports stop sounds verb from TG #28072

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Bm0n
Copy link
Contributor

@Bm0n Bm0n commented Jan 23, 2025

What Does This PR Do

Ports two verbs from TG:

Stop Sounds Special verbs verb that anyone can use. Stops all sounds when used.

Stop Sounds Global Debug verb for those holding sound flags(GA+). Stops sounds for every player when used.

Original PRs/commits from TG:
tgstation/tgstation#1310 (original global verb)
tgstation/tgstation@df18949 (client verb)
tgstation/tgstation#29611 (updated version)

I think I got most of the PRs but dear god this verb was subject to several non-atomic refactors. The code is all from TG with a few edits that I made for paracode/removal of blackbox logging which isn't necessary.

Why It's Good For The Game

Having the ability to stop sounds is useful for when someone does something annoying and you want the sounds to stop (like spam a dozen windup toolboxes beside you)

Admins having the ability to stop all global sound is also useful (like globally stopping sounds in the pre-game lobby so that an OGG can be played and it not interfere with the default lobby music)

Testing

Stop Sounds:

  • Loaded in-game

  • Tested the Stop Sounds while playing a sounds

Stop Sounds Global:

  • Started a VM client and server

  • Connected the VM to the server

  • Played a sound next to the VM client and ran the global command


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added Stop Sounds to the special verbs tab. This verb will stop all playing sound when used.
add: Added Stop Sounds Global to the debug tab. This admin only command will stop all sounds for every player.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants