Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrates /obj/effect to the new attack chain #28066

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Toastical
Copy link
Contributor

@Toastical Toastical commented Jan 23, 2025

What Does This PR Do

migrates /obj/effect to the new attack chain

Why It's Good For The Game

new attack chain

Testing

Behaved as expected

  • /obj/effect
  • /obj/effect/anomaly
  • /obj/effect/cross_action/spacetime_dist
  • /obj/effect/decal
  • /obj/effect/decal/cleanable/tar
  • /obj/effect/dummy/chameleon
  • /obj/effect/guardianshield
  • /obj/effect/hallucination/tripper/spider_web
  • /obj/effect/hierophant
  • /obj/effect/immoratility_talisman
  • /obj/effect/meteor
  • /obj/effect/mob_spawn/human/alive/golem
  • /obj/effect/portal/cult
  • /obj/effect/rend
  • /obj/effect/rune
  • /obj/effect/rune/narsie
  • /obj/effect/snow
  • /obj/effect/spresent

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

NPFC

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants