Adds color boxes to View Variable hex colors #28064
Open
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
reviewed
Jan 22, 2025
ParadiseSS13-Bot
added
the
-Status: Awaiting review
FunnyMan3595
suggested changes
Jan 24, 2025
Co-authored-by: Charlie Nolan <funnyman3595@gmail.com> Signed-off-by: Vi3trice <80771500+Vi3trice@users.noreply.github.com>
code/datums/datumvars.dm
Outdated
| @@ -491,6 +491,9 @@ | |||
| if(isnull(value)) | |||
| item = "[VV_HTML_ENCODE(name)] = <span class='value'>null</span>" | |||
|
|
|||
| else if(is_color_text(value)) | |||
| item = "[VV_HTML_ENCODE(name)] = <span class='value'><span class='colorbox' style='width: 1em; background-color: [value]; border: 1px solid black; display: inline-block'> </span> \"[value]\"</span> | |||
There was a problem hiding this comment.
Suggested change
| item = "[VV_HTML_ENCODE(name)] = <span class='value'><span class='colorbox' style='width: 1em; background-color: [value]; border: 1px solid black; display: inline-block'> </span> \"[value]\"</span> | |
| item = "[VV_HTML_ENCODE(name)] = <span class='value'><span class='colorbox' style='width: 1em; background-color: [value]; border: 1px solid black; display: inline-block'> </span> \"[value]\"</span>" |
Sorry about that, must have dropped a character when copy-pasting.
FunnyMan3595
approved these changes
Jan 24, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds a helper to detect hex colors, and have VV display a colorbox matching the value.
Why It's Good For The Game
Gives a better idea of what you're looking at.
Images of changes
Testing
Spawned a rather colorful mob and VVed it. Also messed with values and saw the resulting changes.
Declaration
Changelog
NPFC