Fix: legacy attackby respects can_be_hit again #27953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
Miraviel
approved these changes
Jan 13, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
warriorstar-orion
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Adds missing parentheses to
/obj/attackby__legacy__attackchain. You can no longer hit objects withcan_be_hit = FALSEWhy It's Good For The Game
Beating a holoray and fire isnt immersive.
Testing
Spawned /obj/effect/holoray and a door. Tried beating the holoray and tried beating the door. The door was attacked, the holoray wasnt.
Cleaned blood with soap.
Declaration
Changelog
🆑
fix: Can't beat fire and holorays anymore
/:cl: