-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] EFTPOS Hacking Key #27742
[FEATURE] EFTPOS Hacking Key #27742
Conversation
!wiki_label |
I am closing this Pull Request for the time being. As for the our current policy with content related to new antagonist features, it requires pre-approval from the team(s) who will be voting on it. This PR may be re-opened when it obtains the approval from at least one member of each of the voting teams, in this case it will be both balance and design. You can find more information about the policy here. https://github.com/ParadiseSS13/Paradise/blob/master/docs/CODE_OF_CONDUCT.md#types-of-changes-that-need-approval |
Thank you for detailed notice! I will reach out to the relevant team members for their input and ensure that the PR meets the necessary requirements. I appreciate the clarification and will review the policy link you shared for better understanding. |
Reopening as proper pre-approval was given. |
e31c512
to
4394ad7
Compare
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammatical touchups/suggestions based on what sounds right and flows better to me.
I do personally feel that having these messages from a single character kinda makes this item stand out in an odd way vs other syndicate items that usually address you as if the syndicate as a whole, rather than from an individual, but that's besides the point.
Co-authored-by: Sheep <46016730+Scribble-Sheep@users.noreply.github.com> Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Thanks a lot, i am struggling with spelling and grammar. You were really helpful! |
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com> Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
@Burzah Hello mister head coder, would you be able to help me with labels on this PR? I am not sure if those are important, if it's just a formality, i apologise for the unnecessary ping. |
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
…istake Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com> Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
…S220 into EFTPOS-Scamer
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
I believe this PR was spoken about in the discussion thread, but as the 30 day period has concluded, this vote ended with a 3 to 3 vote, mixed between both teams. It will be closed at this time. Since it was close, I would suggest reaching out to the design and balance teams again to see if there is anyway you can adjust the PR for it to be more accepted, if you want to pursue it. Comments from our internal tracker are below, with the names of the members removed. Thank you for contributing regardless. People making PRs sparks discussion which leads to changes, even if they aren't from a specific PR. Going to object to this, this feels like it would make people even less likely to pay someone with an EFTPOS as they will always think that it is a hacked one, thus causing issues for non-antags users of a normal EFTPOS. I had concerns about that as well, As I said in the PR or on discord (I forget where), I was only approving if there was some sort of counter introduced. Torn on this as on paper its a neat idea however [REDACTED] provide a good argument about the issues there of it not having a counter. If it was just access being stolen then it would not effect the player directly too much but with account details being taken too? If we are trying to force more of a reliance on the economy and money in general, such things like this that have no counter and can result in your entire account being drained means players will be too suspicious about trying to pay other players for services/goods. objecting this kind of item as it would give even less of a reason for people to use eftpos |
Thanks, for your warm words, and provided feedback. I will strive to make less controversial PR's in future:) it was a fun experience coming up and coding this one. I will not continue working on it, as i don't have solutions to the highlighted problems, if anyone want to finish it fell free to do so. |
What Does This PR Do
Adds a new stealth item to a syndicate uplink EFTPOS hacking key. Comes in a box with instruction. When transactions made by a card with a hacked EFTPOS terminal - account details and some aceses are stolen and stored in terminal. To retrive them agent must use an Agent card to copy stolen aceses and print account details.
Algorithm for stealing aceses: If it's a command personal - steal their "job access" + 3 new random aceses from card, else just steal 3 new random aceses from card.
TC COST = 15
Why It's Good For The Game
My goal with this item was provide an option for antagonist to keep role playing their role i.g. (Bartender, Cook, Hop) and at the same time moving to their goal by acquiring money and access. With introduction of such item i hope more players will choose to play a stealthy, smart agents.
Images of changes
Testing
5)Tested that by swapping a normal card, the key gets the new accesses.
My concern you might run out of space on paper, when printing report with a lot of stolen data, not sure how to better address it
Declaration
Changelog
🆑
add: Added EFTPOS Hacking Key in syndicate uplink
/:cl: