Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] EFTPOS Hacking Key #27742

Closed
wants to merge 21 commits into from
Closed

Conversation

Drsmail
Copy link
Contributor

@Drsmail Drsmail commented Dec 25, 2024

What Does This PR Do

Adds a new stealth item to a syndicate uplink EFTPOS hacking key. Comes in a box with instruction. When transactions made by a card with a hacked EFTPOS terminal - account details and some aceses are stolen and stored in terminal. To retrive them agent must use an Agent card to copy stolen aceses and print account details.

Algorithm for stealing aceses: If it's a command personal - steal their "job access" + 3 new random aceses from card, else just steal 3 new random aceses from card.

TC COST = 15

Why It's Good For The Game

My goal with this item was provide an option for antagonist to keep role playing their role i.g. (Bartender, Cook, Hop) and at the same time moving to their goal by acquiring money and access. With introduction of such item i hope more players will choose to play a stealthy, smart agents.

Images of changes

image
image
image
image

Testing

  1. Tested that you can buy it from uplink.
  2. Tested that you can insert a key into the hops ESTPOS terminal and remove it.
  3. Tested that you can't insert multiple keys.
  4. Tested that you can use an agent card to copy access / print account details.
    5)Tested that by swapping a normal card, the key gets the new accesses.

My concern you might run out of space on paper, when printing report with a lot of stolen data, not sure how to better address it


Declaration

image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added EFTPOS Hacking Key in syndicate uplink
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Dec 25, 2024
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Dec 25, 2024
@Drsmail Drsmail marked this pull request as ready for review December 25, 2024 21:47
@Burzah
Copy link
Member

Burzah commented Dec 26, 2024

I am closing this Pull Request for the time being. As for the our current policy with content related to new antagonist features, it requires pre-approval from the team(s) who will be voting on it. This PR may be re-opened when it obtains the approval from at least one member of each of the voting teams, in this case it will be both balance and design. You can find more information about the policy here. https://github.com/ParadiseSS13/Paradise/blob/master/docs/CODE_OF_CONDUCT.md#types-of-changes-that-need-approval

@Burzah Burzah closed this Dec 26, 2024
@Drsmail
Copy link
Contributor Author

Drsmail commented Dec 26, 2024

I am closing this Pull Request for the time being. As for the our current policy with content related to new antagonist features, it requires pre-approval from the team(s) who will be voting on it. This PR may be re-opened when it obtains the approval from at least one member of each of the voting teams, in this case it will be both balance and design. You can find more information about the policy here. https://github.com/ParadiseSS13/Paradise/blob/master/docs/CODE_OF_CONDUCT.md#types-of-changes-that-need-approval

Thank you for detailed notice! I will reach out to the relevant team members for their input and ensure that the PR meets the necessary requirements. I appreciate the clarification and will review the policy link you shared for better understanding.

@Burzah Burzah reopened this Dec 30, 2024
@Burzah
Copy link
Member

Burzah commented Dec 30, 2024

Reopening as proper pre-approval was given.

@Drsmail
Copy link
Contributor Author

Drsmail commented Dec 30, 2024

@sourcery-ai review

Copy link
Contributor

@Scribble-Sheep Scribble-Sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammatical touchups/suggestions based on what sounds right and flows better to me.

I do personally feel that having these messages from a single character kinda makes this item stand out in an odd way vs other syndicate items that usually address you as if the syndicate as a whole, rather than from an individual, but that's besides the point.

code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
Co-authored-by: Sheep <46016730+Scribble-Sheep@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
@Drsmail
Copy link
Contributor Author

Drsmail commented Jan 4, 2025

Some grammatical touchups/suggestions based on what sounds right and flows better to me.

I do personally feel that having these messages from a single character kinda makes this item stand out in an odd way vs other syndicate items that usually address you as if the syndicate as a whole, rather than from an individual, but that's besides the point.

Thanks a lot, i am struggling with spelling and grammar. You were really helpful!

@DGamerL DGamerL added Feature This PR is a new addition to the game Balance This PR will modify how effective something is or isnt labels Jan 4, 2025
code/datums/uplink_items/uplink_general.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
@Drsmail
Copy link
Contributor Author

Drsmail commented Jan 5, 2025

@Burzah Hello mister head coder, would you be able to help me with labels on this PR? I am not sure if those are important, if it's just a formality, i apologise for the unnecessary ping.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team labels Jan 5, 2025
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
Drsmail and others added 4 commits January 11, 2025 00:07
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
…istake

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 12, 2025
@Drsmail Drsmail requested a review from lewcc January 13, 2025 14:43
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 17, 2025
Signed-off-by: Drsmail <60036448+Drsmail@users.noreply.github.com>
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 20, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 21, 2025
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 25, 2025
@Burzah
Copy link
Member

Burzah commented Jan 29, 2025

I believe this PR was spoken about in the discussion thread, but as the 30 day period has concluded, this vote ended with a 3 to 3 vote, mixed between both teams. It will be closed at this time. Since it was close, I would suggest reaching out to the design and balance teams again to see if there is anyway you can adjust the PR for it to be more accepted, if you want to pursue it. Comments from our internal tracker are below, with the names of the members removed. Thank you for contributing regardless. People making PRs sparks discussion which leads to changes, even if they aren't from a specific PR.


Going to object to this, this feels like it would make people even less likely to pay someone with an EFTPOS as they will always think that it is a hacked one, thus causing issues for non-antags users of a normal EFTPOS.

I had concerns about that as well, As I said in the PR or on discord (I forget where), I was only approving if there was some sort of counter introduced.

Torn on this as on paper its a neat idea however [REDACTED] provide a good argument about the issues there of it not having a counter. If it was just access being stolen then it would not effect the player directly too much but with account details being taken too? If we are trying to force more of a reliance on the economy and money in general, such things like this that have no counter and can result in your entire account being drained means players will be too suspicious about trying to pay other players for services/goods.

objecting this kind of item as it would give even less of a reason for people to use eftpos

@Burzah Burzah closed this Jan 29, 2025
@Drsmail
Copy link
Contributor Author

Drsmail commented Jan 30, 2025

Thank you for contributing regardless. People making PRs sparks discussion which leads to changes, even if they aren't from a specific PR.

Thanks, for your warm words, and provided feedback. I will strive to make less controversial PR's in future:) it was a fun experience coming up and coding this one. I will not continue working on it, as i don't have solutions to the highlighted problems, if anyone want to finish it fell free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game Merge Conflict This PR is merge conflicted Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants