Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Add mantis blades (new traitor item) #27594

Merged
merged 48 commits into from
Jan 17, 2025

Conversation

MiraHell
Copy link
Contributor

@MiraHell MiraHell commented Dec 9, 2024

What Does This PR Do

Adds a new traitor item acquirable through any uplink for 60 TC. For your TC, you receive a box. Inside the box are two autodocs, one for each arm. Once used, they will implant a set of two retractable blades into your body. The Syndicate version deals 20 damage and has 30 armor penetration, while the NT version deals 18 damage and has no armor penetration.
These blades can parry non-projectile attacks, with the Syndicate version having a 75% uptime and the NT version having a 60% uptime. With a cooldown of 1.5 seconds (every second attack), both blades will attack at once. They can also pry open doors when used together. A Nanotrasen version is included and can be printed on a protolathe with Syndicate Tech level 6.

Refactors TRAIT_FORCES_OPEN_DOORS_ITEM into a component at the request of the maintainer

Why It's Good For The Game

A new traitor item with cyberpunk vibes and new double attack mechanics, a more stealthy but weaker weapon than the dsword or chainsaw.

Images of changes

image
On the right is the NT version and the left is syndie
image

Testing

Spawned uplink, bought mantis blades kit, implanted myself, spawned dummy, killed it with blades, spawned airlock, pryed it with two blades. Printed the NT version on protolate, implanted the monkey with it.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
    image


Changelog

🆑
add: Added new traitor item: mantis blades, NT version included on syndicate tech 6
/:cl:

original author: EdgeLordExe
tgstation/tgstation#55936
author of yogstation port: enkidienne
yogstation13/Yogstation#11946

@Toastical
Copy link
Contributor

Toastical commented Dec 9, 2024

Is the double attack cooldown intended to be separate to each arm? Switching your attacking hand allows you to do 2 double attacks back to back consistently.

I cannot tell if the video works.

2024-12-09.16-32-23.mp4

@MiraHell
Copy link
Contributor Author

MiraHell commented Dec 9, 2024

Is the double attack cooldown intended to be separate to each arm? Switching your attacking hand allows you to do 2 double attacks back to back consistently.

It's not intended, thanks for noticing. I'll try to redo the double attack, linter doesn't like the attack call in pre_attack

I cannot tell if the video works.

Works

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 9, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Dec 9, 2024
@MiraHell
Copy link
Contributor Author

MiraHell commented Dec 9, 2024

I need help with the attack chain, I don't understand how it needs to be done

@DGamerL
Copy link
Member

DGamerL commented Dec 10, 2024

I'll try to help tomorrow!

@MiraHell
Copy link
Contributor Author

MiraHell commented Dec 10, 2024

Thanks Warriorstar for the help with nested types. I'm also planning to add the ability to pry open doors with two blades, and then the PR will be ready for review.

@MiraHell
Copy link
Contributor Author

Ready for review ✨

@DGamerL DGamerL added the Balance This PR will modify how effective something is or isnt label Dec 19, 2024
@DGamerL
Copy link
Member

DGamerL commented Jan 1, 2025

Sorry that it's taken so long, I'll take a proper look tomorrow, happy new years!

code/game/machinery/doors/airlock.dm Outdated Show resolved Hide resolved
code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved
code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved
code/modules/surgery/organs/augments_arms.dm Outdated Show resolved Hide resolved
MiraHell and others added 2 commits January 2, 2025 15:09
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com>
Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
@MiraHell MiraHell requested a review from Burzah January 2, 2025 12:25
@MiraHell MiraHell marked this pull request as draft January 11, 2025 15:10
@MiraHell
Copy link
Contributor Author

Draft while I'm working on the component

@MiraHell MiraHell requested a review from lewcc January 11, 2025 15:45
@MiraHell MiraHell marked this pull request as ready for review January 13, 2025 17:57
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the component! I have a few pieces of feedback, but in general it looks good.

code/datums/components/force_door_open.dm Outdated Show resolved Hide resolved
code/datums/components/force_door_open.dm Outdated Show resolved Hide resolved
@MiraHell MiraHell requested a review from lewcc January 14, 2025 18:09
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 16, 2025
@DGamerL DGamerL added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Jan 16, 2025
@Burzah Burzah added this pull request to the merge queue Jan 17, 2025
Merged via the queue into ParadiseSS13:master with commit dac5700 Jan 17, 2025
17 checks passed
@MiraHell MiraHell deleted the add-mantis-blades branch January 17, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants