-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PORT] Add mantis blades (new traitor item) #27594
Conversation
Is the double attack cooldown intended to be separate to each arm? Switching your attacking hand allows you to do 2 double attacks back to back consistently. I cannot tell if the video works. 2024-12-09.16-32-23.mp4 |
It's not intended, thanks for noticing. I'll try to redo the double attack, linter doesn't like the attack call in pre_attack
Works |
I need help with the attack chain, I don't understand how it needs to be done |
I'll try to help tomorrow! |
Thanks Warriorstar for the help with nested types. I'm also planning to add the ability to pry open doors with two blades, and then the PR will be ready for review. |
Ready for review ✨ |
Sorry that it's taken so long, I'll take a proper look tomorrow, happy new years! |
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com> Signed-off-by: Mira <42539014+MiraHell@users.noreply.github.com>
Draft while I'm working on the component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the component! I have a few pieces of feedback, but in general it looks good.
What Does This PR Do
Adds a new traitor item acquirable through any uplink for 60 TC. For your TC, you receive a box. Inside the box are two autodocs, one for each arm. Once used, they will implant a set of two retractable blades into your body. The Syndicate version deals 20 damage and has 30 armor penetration, while the NT version deals 18 damage and has no armor penetration.
These blades can parry non-projectile attacks, with the Syndicate version having a 75% uptime and the NT version having a 60% uptime. With a cooldown of 1.5 seconds (every second attack), both blades will attack at once. They can also pry open doors when used together. A Nanotrasen version is included and can be printed on a protolathe with Syndicate Tech level 6.
Refactors TRAIT_FORCES_OPEN_DOORS_ITEM into a component at the request of the maintainer
Why It's Good For The Game
A new traitor item with cyberpunk vibes and new double attack mechanics, a more stealthy but weaker weapon than the dsword or chainsaw.
Images of changes
On the right is the NT version and the left is syndie
Testing
Spawned uplink, bought mantis blades kit, implanted myself, spawned dummy, killed it with blades, spawned airlock, pryed it with two blades. Printed the NT version on protolate, implanted the monkey with it.
Declaration
I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
🆑
add: Added new traitor item: mantis blades, NT version included on syndicate tech 6
/:cl:
original author: EdgeLordExe
tgstation/tgstation#55936
author of yogstation port: enkidienne
yogstation13/Yogstation#11946