Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SAML): Support attributes with namespace #8931

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

Dschoordsch
Copy link
Contributor

@Dschoordsch Dschoordsch commented Oct 4, 2023

Description

Support Microsoft Entra ID (formaly Azure Active Directory) out of the box. They're sending emailaddress and name prefixed with the http://schemas.xmlsoap.org/ws/2005/05/identity/claims/ namespace. Map those to values we expect.

Instead of stripping all URI prefixes, I decided to just map these explicitly to avoid cases where there could be duplicate values in different namespaces (although extremely unlikely)

Demo

https://www.loom.com/share/6d23e89c31d84ef0b2784e2139d781fb?sid=d850e510-ba6c-47be-b85f-ca665a5edad9

Testing scenarios

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@github-actions github-actions bot added the size/s label Oct 4, 2023
Support Microsoft Entra ID (formaly Azure Active Directory) out of the
box. They're sending `emailaddress` and `name` prefixed with the
http://schemas.xmlsoap.org/ws/2005/05/identity/claims/ namespace.
Map those to values we expect.
@Dschoordsch Dschoordsch requested a review from mattkrick October 4, 2023 21:39
@Dschoordsch Dschoordsch force-pushed the feat/supportSAMLNamespacedAttributes branch from 99226fa to 7de2149 Compare October 4, 2023 21:57
@mattkrick
Copy link
Member

LOVE IT!

@mattkrick mattkrick merged commit 4c29cd6 into master Oct 6, 2023
@mattkrick mattkrick deleted the feat/supportSAMLNamespacedAttributes branch October 6, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants