chore: test sentry and dd uploads #8926
Conversation
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Signed-off-by: Matt Krick <matt.krick@gmail.com>
| @@ -176,11 +179,6 @@ jobs: | |||
| registry: ${{ secrets.GCP_DOCKER_REGISTRY }} | |||
| username: "oauth2accesstoken" | |||
| password: "${{ steps.auth.outputs.access_token }}" | |||
| # | |||
There was a problem hiding this comment.
chances are we'll never build for anything but amd64, but just in case i moved the comments to an issue here:
documented here #8929
| env: | ||
| SENTRY_AUTH_TOKEN: "${{secrets.SENTRY_AUTH_TOKEN}}" | ||
| SENTRY_ORG: "parabol" | ||
| SENTRY_PROJECT: "action-production" |
There was a problem hiding this comment.
Shouldn't we upload it to both action-production and action-staging projects?
There was a problem hiding this comment.
the name is a bit of a misnomer, staging is an environment inside the project action-production.
There was a problem hiding this comment.
🤔 And do we want that? Some time ago I created two new projects in Sentry. Right now we have:
- action-production: used by both Dokku environments (production and staging) in Digital Ocean.
- action-staging: used right now only by the GCP Staging.
- local-development: created in case someone wanted to use sentry in their local environment.
- on-demand-environments: isolated project for the on-demand envs.
I don't really know if that make sense. I created it to isolate the new GCP envs I was building, at least while building and testing.
There was a problem hiding this comment.
IMO a project refers to a codebase. we have 1 project, which is "action", and that is deployed to many environments. In sentry you can search & filter across envs, but not across projects (at least that was the case, not sure if still true).
|
Shouldn't we also remove that uploads from CircleCI on this PR? There is only one case where that might be a problem: a hotfix deployed in production without producing a new tag. And BTW, that would be a problem with our current deployment process and with the future deployment process as well 🤔 |
|
hotfixes create new tags, too. no harm in leaving it in circleCI, assets will just get pushed twice until we get completely off circleCI |
Signed-off-by: Matt Krick <matt.krick@gmail.com>
Description
fixes #8925
Demo
Demo was performed stubbing in
v6.1220.0-exoticfor version & removing theif:clause in the yml✅ Uploaded 234 sourcemaps in 7.214 seconds.(can't confirm in datadog UI 😠 )