chore: remove google language manager #10639
Conversation
|
Hey @mattkrick could you review this for @nickoferrall ? It's also useful for me, as it would remove one more thing from GCP 😸 I want to move the old PPMIs to their new GCP projects and I want to enable only useful APIs 😄 |
There was a problem hiding this comment.
I'm a bit concerned that the demo now operates VERY differently from what happens on the server, specifically that entities won't exist on the server, but it still exists on the demo entities & there's server code that still shows a reference to it. That's gonna get really confusing for us as devs in 6 months from now when we forget what happened here.
My suggestion:
- get rid of all references to GoogleAnalyzedEntities (lemma, salience), including removing it from the GQL schema
- change the demo version of
updateReflectionContentso the logic matches what the server version does. you can have it create a title with OpenAI or use a precanned version, but it shouldn't reference entities because those shouldn't exist anymore
| .filter((word) => word.length > 3) // Skip small words | ||
| .slice(0, 3) | ||
| .join(' ') | ||
| .toLowerCase() |
There was a problem hiding this comment.
+1 what about acronyms or proper nouns?
|
|
||
| const getReflectionEntities = async (plaintextContent: string) => { | ||
| const getBasicLemma = (word: string): string => { |
There was a problem hiding this comment.
-2 this is just too brittle. it'll only work on english, and even then words like "bread" and "Brent" are gonna get recognized as the same lemma. In cases like this, where there's a high likelihood of bad data, we're usually better of with just no data at all.
This PR removes the Google Language Manager now that we're using ChatGPT for reflection group titles (#10546).
The demo continues to use the entities logic.
This also removes the Sentiment Score logic. See Slack discussion here.
To test