Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Cisco AnyConnect Client #313

Closed
Edgarins29 opened this issue Jan 25, 2017 · 5 comments
Closed

[Icon Request] Cisco AnyConnect Client #313

Edgarins29 opened this issue Jan 25, 2017 · 5 comments

Comments

@Edgarins29
Copy link

Hello,
Best icon theme ever, thank you!

Any chance of getting this icon added:
Icon=/opt/cisco/anyconnect/pixmaps/vpnui48.png

Although it seems that there are also many other icons in the /opt/cisco/anyconnect/pixmaps/ path, including systray and systray context menu icons.
vpnui48.png: vpnui48

Systray icons:
systray-connected.png: systray_connected
systray_disconnecting.png: systray_disconnecting
systray_notconnected.png: systray_notconnected
systray_quarantined.png: systray_quarantined
systray_reconnecting.png: systray_reconnecting

Update downloader icon:
downloader-arrow.png: downloader-arrow

Systray context menu icons:
cvc-about.png: cvc-about
cvc-configure.png: cvc-configure
cvc-connect.png: cvc-connect
cvc-disconnect.png: cvc-disconnect
cvc-info.png: cvc-info

Thank you in advance!

Best regards,
Edgars

varlesh added a commit that referenced this issue Jan 26, 2017
@varlesh
Copy link
Contributor

varlesh commented Jan 26, 2017

@Edgarins29 All icons added, if for tray not changed > open request on hardcode-tray and say me new names (if needed)

@Edgarins29
Copy link
Author

Great! Thanks!

They seem to be hardcoded so tried myself to create hardcode-tray database file and after applying looks quite nice, although cvc-about.png seems to be missing at your commit.

Before:
virtualbox_kubuntutesting_26_01_2017_15_29_19

After:
virtualbox_kubuntutesting_26_01_2017_15_30_52

Also manually had to edit desktop file in /usr/share/applications from Icon=/opt/cisco/anyconnect/pixmaps/vpnui48.png to Icon=vpnui so otherwise it wouldn't change. After changing pretty cool:
virtualbox_kubuntutesting_26_01_2017_15_34_38

Also created pull request: bilelmoussaoui/Hardcode-Tray#305

Thank you again!

@bilelmoussaoui
Copy link
Contributor

@Edgarins29 You should give a try to hardcode-fixer, it's the same as Hardcode-Tray but for application icons, it fixes your hardcoded desktop applications files ;)

@Edgarins29
Copy link
Author

Thanks for the tip, will try out that.

varlesh added a commit that referenced this issue Jan 27, 2017
@varlesh
Copy link
Contributor

varlesh commented Jan 27, 2017

@Edgarins29 we not change main app icon or tray menu, because it's not tray icons:

"main": {
            "original": "vpnui48.png",
            "theme": "vpnui"

Fix your PR... and i think need add prefix cisco-, For example:

cisco-systray_notconnected
cisco-systray_reconnecting
# and etc...

varlesh added a commit that referenced this issue Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants