[ci skip] Mention API Checks for CONTRIBUTING.md #12315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
reviewed
Mar 19, 2025
Co-authored-by: Nassim Jahnke <nassim@njahnke.dev>
Co-authored-by: Nassim Jahnke <nassim@njahnke.dev>
|
I'm not a fan of the example picked sendMessageComponent is ambiguous either you want to send a plain/mini message in that case rename the methods to match the api or a full component. Currently it looks like we support legacy formatting here. There should be also a mention about checkNotNull case (to not use it for the described reason). |
…xt and pretty sure use the serializer is a bad idea here then just change that example for another and ready
kennytv
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to add a mention in CONTRIBUTING.md for API Checks mostly because its a thing mentioned in PR/discord but not here.
Also try to include example using the formated methods. based in the Spigot mention of Preconditions.