Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add biome change per player #11799

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yannicklamprecht
Copy link
Contributor

resolves #9889

pre hard fork: #10284

TODO:

  • Implement and call event
  • finish implementing BiomesSnapshot
  • add a handle to Chunk
  • test api with plugin
  • test compatibility with plugins using PlayerChunkLoadEvent
  • reduce diff
  • add paper comments

@kennytv kennytv added the type: feature Request for a new Feature. label Dec 24, 2024
@yannicklamprecht yannicklamprecht force-pushed the issue/9889-chunk-biome-packets-new branch from e97d44f to 4151472 Compare December 24, 2024 16:13
import org.jspecify.annotations.NullMarked;

/**
* Is called when a {@link Player} receives {@link org.bukkit.block.Biome}s
Copy link

@ShaneBeee ShaneBeee Dec 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Is called when a {@link Player} receives {@link org.bukkit.block.Biome}s
* Is called when a {@link Player} receives {@link org.bukkit.block.Biome Biomes}

Looks nicer in the javadocs

Exhibit A:
Screenshot 2024-12-24 at 7 04 27 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plural doesn't seem to work then. At least what I can see in your screen shoot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

Change biomes per-player in chunk/biome packets
3 participants