Add DamageType RegistryEvent

[Chaosdave34]

Add RegistryEvent for DamageType

Changes:

• Add DamageTypeRegistryEntry
• Add PaperDamageTypeRegistryEntry
• Make DamageType PaperRegistry writeable
• Add DamageType Event to RegistryEvents

But I ran into the problem, that DamageEffect uses Bukkit.getUnsafe() for initialization and that seems to be not available at bootstrap. I fixed that with the following changes, but I am not sure if that's the correct way to do is as it may break plugins:

• Turn DamageType interface into an enum
• Add CraftDamageType damageEffectToBukkit() and damageEffectToNMS() to CraftDamageType
• Add getSoundForDamageEffect() to UnsafeValues (and CraftMagicNumbers)
• Deprecated CraftDamageEffect, UnsafeValues#getDamageEffect() and DamageEffect#getDamageEffect()

The only breaking change I see is when someone tries to cast DamageType to CraftDamageType which is no longer possible with my approach.

[Machine-Maker]

As for the StaticUnsafeValues, I have a slightly different idea on how to solve it, but it can just be left in for now, not a big deal.

There should be a standardized way to interact with the "pseudo-registries" types of which DamageEffect is part of. All the types on the server that implement StringRepresentable are a different sort of registry where there is a defined mapping between a string and an instance. There will be/already are other cases where a way to convert between them would be useful if we don't want to use an enum on the API side.

But this isn't something you have to figure out, that'll be for us to decide on.

[lynxplay]

Totally missed it on my first review, but welcome to paper 🥳
Great first PR and thank you for your work!

[Chaosdave34]

Totally missed it on my first review, but welcome to paper 🥳 Great first PR and thank you for your work!

Tyvm!

Although you might missed this one.

[lynxplay]

Well get congratulated twice then xD