Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose server build information #10729

Merged
merged 3 commits into from
May 16, 2024
Merged

Expose server build information #10729

merged 3 commits into from
May 16, 2024

Conversation

kashike
Copy link
Member

@kashike kashike commented May 15, 2024 •
edited
Loading

Server startup & /version:

This server is running Paper version 1.20.6-DEV-feature/better-version@c1d8c2e (2024-05-15T21:19:32Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
This server is running Paper version 1.20.6-205-feature/better-version@c1d8c2e (2024-05-15T21:21:30Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)

Bukkit.getVersion():

1.20.6-DEV-c1d8c2e (MC: 1.20.6)
1.20.6-205-c1d8c2e (MC: 1.20.6)

DEV will be replaced with a real build number (ex: 204) when built using TeamCity.

@kashike kashike requested a review from a team as a code owner May 15, 2024 01:42
@kashike kashike added the type: feature Request for a new Feature. label May 15, 2024
@kashike kashike force-pushed the feature/better-version branch from 1f3499d to 6bf6a58 Compare May 15, 2024 06:36
@kashike kashike changed the title feat: better versioning Expose server build information May 15, 2024
@kashike kashike mentioned this pull request May 15, 2024
Closed
@kashike kashike force-pushed the feature/better-version branch 2 times, most recently from 0b6c151 to bbdf92e Compare May 15, 2024 20:35
Machine-Maker
Machine-Maker requested changes May 15, 2024
View reviewed changes
Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. And when its done we have to merge the several patches that all touch version stuff and probably put this at the beginning of the patches.

patches/api/0480-Expose-server-build-information.patch Outdated Show resolved Hide resolved
patches/api/0480-Expose-server-build-information.patch Outdated Show resolved Hide resolved
patches/api/0480-Expose-server-build-information.patch Outdated Show resolved Hide resolved
@kashike kashike force-pushed the feature/better-version branch 6 times, most recently from 1f38623 to c1d8c2e Compare May 15, 2024 21:19
@kashike @Machine-Maker @masmc05
Expose server build information
8a8eb09 
Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
Co-authored-by: masmc05 <masmc05@gmail.com>
@kashike kashike force-pushed the feature/better-version branch from c1d8c2e to 8a8eb09 Compare May 15, 2024 21:28
@kashike
Copy link
Member Author

kashike commented May 15, 2024

FYI: We're going to be squashing a bunch of previous patches dealing with versioning into one mega-patch.

@Machine-Maker Machine-Maker merged commit f175193 into master May 16, 2024
5 checks passed
@Machine-Maker Machine-Maker deleted the feature/better-version branch May 16, 2024 00:07
@powercasgamer powercasgamer mentioned this pull request May 29, 2024
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees

@Machine-Maker Machine-Maker

Labels
type: feature Request for a new Feature.
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashike @Machine-Maker