Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datapack registration lifecycle event #10711

Closed
wants to merge 1 commit into from
Closed

Add datapack registration lifecycle event #10711

wants to merge 1 commit into from
+1,057 −0

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented May 13, 2024 •
edited
Loading

Replaces #8865. Way better to be able to set it up as you like instead of one hardcoded in the paper-plugin.yml.

Tasks
Preview Give feedback

@Machine-Maker Machine-Maker mentioned this pull request May 13, 2024
Closed
@Machine-Maker Machine-Maker marked this pull request as ready for review May 13, 2024 03:11
@Machine-Maker Machine-Maker requested a review from a team as a code owner May 13, 2024 03:11
@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 2bccd25 to 7adb8a5 Compare May 29, 2024 00:13
@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 6148b92 to 3d5b270 Compare June 16, 2024 21:04
@Machine-Maker Machine-Maker changed the base branch from master to dev/1.21 June 16, 2024 21:59
@Machine-Maker Machine-Maker changed the base branch from dev/1.21 to master June 17, 2024 19:25
@olijeffers0n olijeffers0n mentioned this pull request Jun 23, 2024
Open
@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 3d5b270 to 6741929 Compare August 20, 2024 03:58
@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 6741929 to a02c120 Compare September 8, 2024 22:51
@Machine-Maker Machine-Maker mentioned this pull request Sep 8, 2024
Open
@Machine-Maker Machine-Maker linked an issue Sep 8, 2024 that may be closed by this pull request
Can't enable/disable a datapack on startup #11242
Open
@Machine-Maker
Copy link
Member Author

I've added additional methods to the DatapackRegistrar to get previously discovered packs as well as remove previously discovered packs.

@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 7730a7f to 9b2e78e Compare September 15, 2024 20:30
@Machine-Maker Machine-Maker force-pushed the feature/datapack-lifecycle-event branch from 9b2e78e to bf66c7c Compare September 23, 2024 23:21
@Machine-Maker Machine-Maker deleted the feature/datapack-lifecycle-event branch December 24, 2024 02:47
@Machine-Maker Machine-Maker mentioned this pull request Dec 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pre-softspoon
Projects
Paper PR Queue
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't enable/disable a datapack on startup
2 participants
@Machine-Maker @MiniDigger