Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change biomes per-player in chunk/biome packets #9889

Closed
Machine-Maker opened this issue Oct 29, 2023 · 0 comments · May be fixed by #11799
Closed

Change biomes per-player in chunk/biome packets #9889

Machine-Maker opened this issue Oct 29, 2023 · 0 comments · May be fixed by #11799
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.

Comments

@Machine-Maker
Copy link
Member

Is your feature request related to a problem?

There isn't a way to set biomes to be per-player

Describe the solution you'd like.

In the PlayerChunkLoadEvent or a new superevent of that, there should be a way to change the biome data sent to the client in order for each player to be able to get a different set of biomes.

I think this has to be a new superevent of PlayerChunkLoadEvent because biomes can change independent of chunks being sent to the client with the new fillbiome command. There is also a specific packet for changing a chunk biomes.

Describe alternatives you've considered.

N/A

Other

I'm not sure of the correct API structure for representing chunk biomes. Generally, I think it would be beneficial if plugins could create chunk biome data arbitrarily to they aren't creating new PalettedContainers for every player. Having some way plugins could create biome data, cache it, and then use it for specific players would be ideal.

ChunkSnapshot is a good place to start. It wraps around 2 arrays of PalettedContainers for blockstates and biomes. Having a supertype of that which just wraps biomes seems like a good idea.

Something to note is that the array of PalettedContainer for biomes has a different length depending on the height of the world. So care would have to be taken to ensure that the sizes matched.

@Machine-Maker Machine-Maker added type: feature Request for a new Feature. status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. labels Oct 29, 2023
@PaperMC PaperMC locked and limited conversation to collaborators Apr 28, 2024
@codebycam codebycam converted this issue into discussion #10593 Apr 28, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: feature Request for a new Feature.
Projects
None yet
1 participant