better support for future direct buildables

PaperMC · Dec 25, 2024 · 6f7cabf · 6f7cabf
1 parent c7d0436
commit 6f7cabf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/paper-server/src/main/java/io/papermc/paper/registry/PaperRegistryBuilderFactory.java b/paper-server/src/main/java/io/papermc/paper/registry/PaperRegistryBuilderFactory.java
@@ -2,7 +2,6 @@
 
 import io.papermc.paper.adventure.PaperAdventure;
 import io.papermc.paper.registry.data.util.Conversions;
-import io.papermc.paper.registry.entry.RegistryEntryMeta;
 import java.util.function.Function;
 import net.minecraft.resources.ResourceLocation;
 import org.bukkit.Keyed;
@@ -11,13 +10,13 @@
 public class PaperRegistryBuilderFactory<M, A extends Keyed, B extends PaperRegistryBuilder<M, A>> implements RegistryBuilderFactory<A, B> { // TODO remove Keyed
 
     private final Conversions conversions;
-    private final RegistryEntryMeta.Buildable<M, A, B> meta;
+    private final PaperRegistryBuilder.Filler<M, A, B> builderFiller;
     private final Function<? super ResourceLocation, ? extends @Nullable M> existingValueGetter;
     private @Nullable B builder;
 
-    public PaperRegistryBuilderFactory(final Conversions conversions, final RegistryEntryMeta.Buildable<M, A, B> meta, final Function<? super ResourceLocation, ? extends @Nullable M> existingValueGetter) {
+    public PaperRegistryBuilderFactory(final Conversions conversions, final PaperRegistryBuilder.Filler<M, A, B> builderFiller, final Function<? super ResourceLocation, ? extends @Nullable M> existingValueGetter) {
         this.conversions = conversions;
-        this.meta = meta;
+        this.builderFiller = builderFiller;
         this.existingValueGetter = existingValueGetter;
     }
 
@@ -37,7 +36,7 @@ public B requireBuilder() {
     @Override
     public B empty() {
         this.validate();
-        return this.builder = this.meta.builderFiller().create(this.conversions);
+        return this.builder = this.builderFiller.create(this.conversions);
     }
 
     @Override
@@ -47,6 +46,6 @@ public B copyOf(final TypedKey<A> key) {
         if (existing == null) {
             throw new IllegalArgumentException("Key " + key + " doesn't exist");
         }
-        return this.builder = this.meta.builderFiller().fill(this.conversions, existing);
+        return this.builder = this.builderFiller.fill(this.conversions, existing);
     }
 }
diff --git a/paper-server/src/main/java/io/papermc/paper/registry/WritableCraftRegistry.java b/paper-server/src/main/java/io/papermc/paper/registry/WritableCraftRegistry.java
@@ -31,7 +31,7 @@ public WritableCraftRegistry(
     public void register(final TypedKey<T> key, final Consumer<RegistryBuilderFactory<T, B>> value, final Conversions conversions) {
         final ResourceKey<M> resourceKey = PaperRegistries.toNms(key);
         this.registry.validateWrite(resourceKey);
-        final PaperRegistryBuilderFactory<M, T, B> builderFactory = new PaperRegistryBuilderFactory<>(conversions, this.meta, this.registry.temporaryUnfrozenMap::get);
+        final PaperRegistryBuilderFactory<M, T, B> builderFactory = new PaperRegistryBuilderFactory<>(conversions, this.meta.builderFiller(), this.registry.temporaryUnfrozenMap::get);
         value.accept(builderFactory);
         PaperRegistryListenerManager.INSTANCE.registerWithListeners(
             this.registry,