Changed test to use lower case names consistent with PVA

[evalott100]

Closes #13

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7499b9) 83.50% compared to head (ec9cc23) 83.50%.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev      #22   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files           7        7           
  Lines        1073     1073           
=======================================
  Hits          896      896           
  Misses        177      177           

Impacted Files	Coverage Δ
src/pandablocks_ioc/_tables.py	95.85% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[AlexanderWells-diamond]

Is this a correct understanding of the situation?

We create a series of records for the tables, and we pass in the name of each column as an extra bit of info. As PandA returns that name in capitals, we pass it in like that, but then PVI is internally converting it to lower case? Is that an expected behaviour? It seems like an odd bit of unnecessary work that it's doing.

[evalott100]

Is this a correct understanding of the situation?

We create a series of records for the tables, and we pass in the name of each column as an extra bit of info. As PandA returns that name in capitals, we pass it in like that, but then PVI is internally converting it to lower case? Is that an expected behaviour? It seems like an odd bit of unnecessary work that it's doing.

@coretl mentioned this maybe he can weight in? I remember hearing that names will be capitalised and made lowercase at different points in the I22 run we're planning

[coretl]

That is correct, we need the names in the PVI structure, and the names in the PVA table structure to be lowercase, as we tie python attribute names to this in Ophyd...

[AlexanderWells-diamond]

Sorry, I don't quite get it: We create the PVI name tags, and we're creating them in uppercase? But then when we receive them through pvget we see lowercase strings? I don't see how Ophyd is related to what I believe is happening entirely inside this codebase?

[coretl]

In this line I make the PVA table column lowercase:

PandABlocks-ioc/src/pandablocks_ioc/_tables.py

Line 317 in a8586b9

f"value.{field_name.lower()}": {

This makes the same name to the tests.

In #18 I also make the PVI structure name lowercase, so that's not actually part of this PR...