Adjust to use table packing in utils #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does now mean we do a lot more re-ordering of the list, but the alternative is to keep two lists which would more easily become out of sync.
This applies to any PandA field that returns us a label field. Tests updated to accomodate this.
Also fixes some mypy errors in tests
Also upgrade to newest pythonSoftIoc which includes waveform of strings support. Also adjust typing of some test fixtures to better indicate that the order of items is important
Also raise exception if initial connect fails.
Also improves the IOC startup, by waiting for a signal rather than just a flat sleep timer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Should only be merged after PandABlocks/PandABlocks-client#52