Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change structure of pvi pv #136

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Change structure of pvi pv #136

merged 4 commits into from
Oct 15, 2024

Conversation

evalott100
Copy link
Contributor

Closes #120

@evalott100
Copy link
Contributor Author

[:)] pvget -v PANDA1:PVI
PANDA1:PVI epics:nt/NTPVI:1.0 
    structure record
        structure _options
            boolean atomic true
    alarm_t alarm 
        int severity 0
        int status 0
        string message 
    time_t timeStamp 2024-10-08 10:18:42.815  
        long secondsPastEpoch 1728379122
        int nanoseconds 814974146
        int userTag 0
    structure display
        string description PVs making up Interface for entire panda.
    structure value
        structure bits
            string d PANDA1:BITS:PVI
        structure calc1
            string d PANDA1:CALC1:PVI
        structure calc2
            string d PANDA1:CALC2:PVI
        ...

and

[:)] pvget -v PANDA1:TTLOUT9:PVI    
PANDA1:TTLOUT9:PVI epics:nt/NTPVI:1.0 
    structure record
        structure _options
            boolean atomic true
    alarm_t alarm 
        int severity 0
        int status 0
        string message 
    time_t timeStamp 2024-10-08 10:18:42.816  
        long secondsPastEpoch 1728379122
        int nanoseconds 815666823
        int userTag 0
    structure display
        string description PVs making up Interface for TTLOUT9
    structure value
        structure label
            string rw PANDA1:TTLOUT9:LABEL
        structure val
            string rw PANDA1:TTLOUT9:VAL
        structure val_delay
            string rw PANDA1:TTLOUT9:VAL:DELAY

@evalott100 evalott100 requested a review from coretl October 8, 2024 09:20
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.67%. Comparing base (c4dea92) to head (7626f2a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   91.32%   91.67%   +0.35%     
==========================================
  Files           8        8              
  Lines        1372     1382      +10     
  Branches      219      162      -57     
==========================================
+ Hits         1253     1267      +14     
  Misses         82       82              
+ Partials       37       33       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/pandablocks_ioc/_pvi.py Outdated Show resolved Hide resolved
Can easily change from `.value` to `.pvi`.
@evalott100
Copy link
Contributor Author

Now we have both:

[:)] pvget -v PANDA1:OUTENC1:PVI
PANDA1:OUTENC1:PVI epics:nt/NTPVI:1.0 
    structure record
        structure _options
            boolean atomic true
    alarm_t alarm 
        int severity 0
        int status 0
        string message 
    time_t timeStamp 2024-10-15 14:40:50.304  
        long secondsPastEpoch 1728999650
        int nanoseconds 303598050
        int userTag 0
    structure display
        string description PVs making up Interface for OUTENC1
    structure pvi
        structure a
            string rw PANDA1:OUTENC1:A
        structure a_delay
            string rw PANDA1:OUTENC1:A:DELAY
        structure b
            string rw PANDA1:OUTENC1:B
        structure b_delay
            string rw PANDA1:OUTENC1:B:DELAY
        structure bits
            string rw PANDA1:OUTENC1:BITS
        structure clk
            string r PANDA1:OUTENC1:CLK
        structure data
            string rw PANDA1:OUTENC1:DATA
        structure data_delay
            string rw PANDA1:OUTENC1:DATA:DELAY
        structure dcard_type
            string r PANDA1:OUTENC1:DCARD_TYPE
        structure enable
            string rw PANDA1:OUTENC1:ENABLE
        structure enable_delay
            string rw PANDA1:OUTENC1:ENABLE:DELAY
        structure encoding
            string rw PANDA1:OUTENC1:ENCODING
        structure generator_error
            string rw PANDA1:OUTENC1:GENERATOR_ERROR
        structure health
            string r PANDA1:OUTENC1:HEALTH
        structure label
            string rw PANDA1:OUTENC1:LABEL
        structure protocol
            string rw PANDA1:OUTENC1:PROTOCOL
        structure qperiod
            string rw PANDA1:OUTENC1:QPERIOD
        structure qperiod_units
            string rw PANDA1:OUTENC1:QPERIOD:UNITS
        structure qstate
            string r PANDA1:OUTENC1:QSTATE
        structure val
            string rw PANDA1:OUTENC1:VAL
        structure z
            string rw PANDA1:OUTENC1:Z
        structure z_delay
            string rw PANDA1:OUTENC1:Z:DELAY
    structure value
        structure a
            string rw PANDA1:OUTENC1:A
        structure a_delay
            string rw PANDA1:OUTENC1:A:DELAY
        structure b
            string rw PANDA1:OUTENC1:B
        structure b_delay
            string rw PANDA1:OUTENC1:B:DELAY
        structure bits
            string rw PANDA1:OUTENC1:BITS
        structure clk
            string r PANDA1:OUTENC1:CLK
        structure data
            string rw PANDA1:OUTENC1:DATA
        structure data_delay
            string rw PANDA1:OUTENC1:DATA:DELAY
        structure dcard_type
            string r PANDA1:OUTENC1:DCARD_TYPE
        structure enable
            string rw PANDA1:OUTENC1:ENABLE
        structure enable_delay
            string rw PANDA1:OUTENC1:ENABLE:DELAY
        structure encoding
            string rw PANDA1:OUTENC1:ENCODING
        structure generator_error
            string rw PANDA1:OUTENC1:GENERATOR_ERROR
        structure health
            string r PANDA1:OUTENC1:HEALTH
        structure label
            string rw PANDA1:OUTENC1:LABEL
        structure protocol
            string rw PANDA1:OUTENC1:PROTOCOL
        structure qperiod
            string rw PANDA1:OUTENC1:QPERIOD
        structure qperiod_units
            string rw PANDA1:OUTENC1:QPERIOD:UNITS
        structure qstate
            string r PANDA1:OUTENC1:QSTATE
        structure val
            string rw PANDA1:OUTENC1:VAL
        structure z
            string rw PANDA1:OUTENC1:Z
        structure z_delay
            string rw PANDA1:OUTENC1:Z:DELAY

@evalott100 evalott100 merged commit ee7d927 into main Oct 15, 2024
20 checks passed
@evalott100 evalott100 deleted the 120-change-structure-of-pvi-PV branch October 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change structure of pvi PV
2 participants